Uploaded image for project: 'Maven Shared Components'
  1. Maven Shared Components
  2. MSHARED-608

Remove index.html-adding block in AbstractMavenReportRenderer#getValidHref()

    Details

      Description

      If URL validation fails, the following is executed:

      String hrefTmp;
      if ( !href.endsWith( "/" ) )
      {
        hrefTmp = href + "/index.html";
      }
      else
      {
        hrefTmp = href + "index.html";
      }
      
      if ( UrlValidationUtil.isValidUrl( hrefTmp ) )
      {
        return href;
      }
      

      There are several problems here:

      • The assumption that / will point to index.html is wrong. This is not known. It can ultimately lead to 404. No assumption shall be made to the target.
      • There is no way that if a URL is already invalid it will get a valid URL by adding index.html.

      Remove this code block.

        Attachments

          Activity

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: