Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: file-management-1.2
    • Fix Version/s: None
    • Component/s: file-management
    • Labels:
      None
    • Environment:
      all
    • Flags:
      Patch

      Description

      Hi guys I have created a patch for the MASSEMBLY-342 that should be applied to FileSetManager. This patch fixes a but that can arise if you make assemblies and in your assembly-descriptor you have filesets that don't specify directory.
      For further info please look here:
      http://jira.codehaus.org/browse/MASSEMBLY-342

      1. mshared55-ver1-testcase.txt
        2 kB
        Petar Tahchiev
      2. mshared55-ver.1.txt
        1 kB
        Petar Tahchiev
      3. massembly-342.txt
        1 kB
        Petar Tahchiev

        Issue Links

          Activity

          Petar Tahchiev created issue -
          Petar Tahchiev made changes -
          Field Original Value New Value
          Link This issue is related to MASSEMBLY-342 [ MASSEMBLY-342 ]
          Petar Tahchiev made changes -
          Link This issue relates to MASSEMBLY-297 [ MASSEMBLY-297 ]
          Petar Tahchiev made changes -
          Link This issue is depended upon by MASSEMBLY-297 [ MASSEMBLY-297 ]
          Hide
          Petar Tahchiev added a comment -

          I have made a new version of the patch, because I noticed a few problems with the old one. Please use MSHARED-55-ver1 patch.

          Show
          Petar Tahchiev added a comment - I have made a new version of the patch, because I noticed a few problems with the old one. Please use MSHARED-55 -ver1 patch.
          Petar Tahchiev made changes -
          Attachment mshared55-ver.1.txt [ 36692 ]
          Hide
          Petar Tahchiev added a comment -

          Here is a junit test-case that tests if we specify a fileset with no directory that we get nothing included.

          Show
          Petar Tahchiev added a comment - Here is a junit test-case that tests if we specify a fileset with no directory that we get nothing included.
          Petar Tahchiev made changes -
          Attachment mshared55-ver1-testcase.txt [ 36693 ]
          Benjamin Bentmann made changes -
          Affects Version/s file-management 1.2 [ 14543 ]
          Hide
          Benjamin Bentmann added a comment -

          Petar, I am not sure whether your patch really solves MASSEMBLY-342. You are simply avoiding the NPE in the FileSetManager but as far as I understand, the NPE is adequate: A required parameter is missing and I wouldn't consider a FileSet without base directory a valid object. The Assembly Plugin is responsible to properly configure the FileSet before passing it down to the FileSetManager, so that needs fixing. In particular, consider the POM snippet given over at the MASSEMBLY-342

          <fileSet>
            <filtered>true</filtered>
            <includes>
              <include>INSTALL*</include>
              <include>README*</include>
              <include>LICENSE*</include>
              <include>NOTICE*</include>
            </includes>
          </fileSet>
          

          which suggests that the user wants the FileSet to use the project's base directory. This is a completely different semantics than just returning an empty result list.

          To summarize: I think this issue itself should be closed as "Won't fix". To real work is over in the Assembly Plugin.

          Show
          Benjamin Bentmann added a comment - Petar, I am not sure whether your patch really solves MASSEMBLY-342 . You are simply avoiding the NPE in the FileSetManager but as far as I understand, the NPE is adequate: A required parameter is missing and I wouldn't consider a FileSet without base directory a valid object. The Assembly Plugin is responsible to properly configure the FileSet before passing it down to the FileSetManager, so that needs fixing. In particular, consider the POM snippet given over at the MASSEMBLY-342 <fileSet> <filtered> true </filtered> <includes> <include> INSTALL* </include> <include> README* </include> <include> LICENSE* </include> <include> NOTICE* </include> </includes> </fileSet> which suggests that the user wants the FileSet to use the project's base directory. This is a completely different semantics than just returning an empty result list. To summarize: I think this issue itself should be closed as "Won't fix". To real work is over in the Assembly Plugin.
          Benjamin Bentmann made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Assignee Benjamin Bentmann [ bentmann ]
          Resolution Won't Fix [ 2 ]
          Benjamin Bentmann made changes -
          Link This issue relates to MASSEMBLY-297 [ MASSEMBLY-297 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 13:14:21 UTC 2015 [ 1428239661755 ]
          Mark Thomas made changes -
          Workflow jira [ 12726066 ] Default workflow, editable Closed status [ 12764534 ]
          Mark Thomas made changes -
          Patch Submitted Yes [ 10763 ]
          Flags Patch [ 10430 ]
          Mark Thomas made changes -
          Project Import Mon Apr 06 01:15:59 UTC 2015 [ 1428282959282 ]
          Mark Thomas made changes -
          Workflow jira [ 12963928 ] Default workflow, editable Closed status [ 13000228 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          16d 22h 32m 1 Benjamin Bentmann 11/Sep/08 14:27

            People

            • Assignee:
              Benjamin Bentmann
              Reporter:
              Petar Tahchiev
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development