Uploaded image for project: 'Maven Shared Components'
  1. Maven Shared Components
  2. MSHARED-495

Add convenience method to move code into Maven Filtering

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: maven-filtering-3.0.0
    • Fix Version/s: maven-filtering-3.1.0
    • Component/s: None
    • Labels:
      None

      Description

      A few plugins contain the following code which belong into maven-filtering instead:

              if ( delimiters != null && !delimiters.isEmpty() )
              {
                  LinkedHashSet<String> delims = new LinkedHashSet<String>();
                  if ( useDefaultDelimiters )
                  {
                      delims.addAll( this.getDelimiters() );
                  }
      
                  for ( String delim : delimiters )
                  {
                      if ( delim == null )
                      {
                          // FIXME: ${filter:*} could also trigger this condition. Need a better long-term solution.
                          delims.add( "${*}" );
                      }
                      else
                      {
                          delims.add( delim );
                      }
                  }
      
                  this.setDelimiters( delims );
      

      Moving this code into maven-fitlering where it belongs. New method introduced:

      setDelimiters( LinkedHashSet<String> delimiters, boolean useDefaultDelimiters )
      

        Attachments

          Activity

            People

            • Assignee:
              khmarbaise Karl Heinz Marbaise
              Reporter:
              khmarbaise Karl Heinz Marbaise
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: