[MSHARED-489] AbstractMavenReportRenderer#linkPatternedText ignores name if href is invalid

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-reporting-impl 2.4
• Fix Version/s: maven-reporting-impl 3.0
• Component/s: maven-reporting-impl
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 05/Jan/16 00:42
• Updated: 04/Feb/17 21:14
• Resolved: 04/Feb/17 21:14

Description

Consider this input:

{My Text, ftp://host/file.txt} or {My Text, http:/host/file.txt} (typo)

The current output simply be ftp://host/file.txt or http:/host/file.txt but I would expect it to be My Text in both cases.

The problem is burried in the current code:

for ( Iterator<String> it = segments.iterator(); it.hasNext(); )
{
    String name = it.next();
    String href = it.next();

    if ( href == null )
    {
        text( name );
    }
    else
    {
        if ( getValidHref( href ) != null )
        {
            link( getValidHref( href ), name );
        }
        else
        {
            text( href );
        }
    }
}

The invalid href would be printed out instead of name. I think the code should read:

for ( Iterator<String> it = segments.iterator(); it.hasNext(); )
{
    String name = it.next();
    String href = it.next();

    if ( getValidHref( href ) == null )
    {
        text( name );
    }
    else
    {
        link( getValidHref( href ), name );
    }
}

Produce link if href isn't null and is valid otherwise add name (text) only.

Issue Links

• is part of: MSHARED-611 Drop any href validation and pass as-is
• is related to: MSHARED-429 Supposedly invalid URLs are rendered as plain text