[MSHARED-1077] Common Artifact Filters pattern parsing with classifier is broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: maven-common-artifact-filters-3.3.0
• Component/s: maven-common-artifact-filters
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 08/Jun/22 07:37
• Updated: 11/Jun/22 13:36
• Resolved: 11/Jun/22 13:36

Description

The parsing of patterns containing classifier was broken, it allowed only ANY (asterisk) for classifier, that breaks and is not in line with pattern definition. Moreover, the code was really cryptic, and low-level in way it was really hard to understand what is really happening.

Rewrite the code using high level Java, but retain (or improve) the speed gain as well, and fix the parsing of patterns having classifiers.

Issue Links

• causes: MASSEMBLY-955 dependencySet includes filter with classifier breaks include of artifacts without classifier
• fixes: MSHARED-1031 PatternIncludesArtifactFilter#include(Artifact)
• links to: GH PR #26
• links to: GitHub Pull Request #26