[MSHARED-1017] null passed to DependencyFilter in EclipseAetherFilterTransformerTest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-common-artifact-filters-3.2.0
• Fix Version/s: maven-common-artifact-filters-3.3.0
• Component/s: maven-common-artifact-filters
• Assignee: Michael Osipov
• Reporter: Marián Konček
• Created: 06/Jan/22 12:50
• Updated: 15/Jan/22 09:38
• Resolved: 15/Jan/22 09:38

Description

The tests in EclipseAetherFilterTransformerTest.java contain calls like `assertTrue( dependencyFilter.accept( newDependencyNode( "g:a:v", "compile" ), null ) );`.
The API of DependencyFilter states that the second parameter may not be null:
https://maven.apache.org/resolver/maven-resolver-api/apidocs/org/eclipse/aether/graph/DependencyFilter.html
The issue was encountered when executing the tests with maven-resolver-util version 1.7.3 and causes maven build to fail because maven-resolver added requireNonNull in some release after 1.4.2 which is the declared dependency.

Attaching proposed patch.