[MSHADE-417] Fix null bytes appended to small files by maven-shade-plugin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.4.1
• Assignee: Guillaume Nodet
• Reporter: Max Zerzouri
• Created: 31/Mar/22 02:33
• Updated: 20/Oct/22 21:20
• Resolved: 20/Oct/22 20:36

Description

Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if it's less than 4 bytes:

$ echo -n a > src/main/resources/test.txt
$ mvn clean install
...
$ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
00000000: 61                                       a
$ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
00000000: 6100 0000                                a...

I've attached a basic pom.xml that triggers this. This doesn't occur in the previous version, 3.2.4.

Issue Links

• is broken by: MSHADE-378 Shade plugin changes the compression level of nested jar entries
• links to: GitHub Pull Request #140
• links to: GitHub Pull Request #160