[MSHADE-305] Filters are merged by index, not by artifactId

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 3.0.0
• Environment: Maven 3.2.5, Windows&Unix
• Assignee: Robert Scholte
• Reporter: Chesnay Schepler
• Created: 12/Dec/18 10:25
• Updated: 12/Dec/18 19:47
• Resolved: 12/Dec/18 19:47

Description

When filters are defined in both a parent and child module they are merged by index, and not by artifactId.

For example, consider these 2 filters:

Parent:

<filter>
    <artifact>IDontEvenExist</artifact>
    <excludes>
        <exclude>**</exclude>
    </excludes>
</filter>

Child:

<filter>
    <artifact>org.apache.flink:IncludedModule</artifact>
    <includes>
        <include>**</include>
    </includes>
</filter>

Despite the filters being defined for distinct artifacts they are still merged into the following filter, which excludes everything from IncludedModule.

<filter>
    <artifact>org.apache.flink:IncludedModule</artifact>
    <includes>
        <include>**</include>
    </includes>
    <excludes>
        <exclude>**</exclude>
    </excludes>
</filter>

I have attached a reproducer.

A trivial workaround is to add combine.children="append" to <filters>.

I would expect that either filters are merged by artifactId or at the very least a warning is printed if filters are merged this way.

Issue Links

• causes: FLINK-11085 NoClassDefFoundError in presto-s3 filesystem