Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-257

Bad zero length source jars published by 3rd parties cause source jar creation to fail.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.1.0
    • Labels:
      None

      Description

      If a transient dependency that is being shaded (in my case xmlpull:xmlpull:1.1.3.1) published a zero length source jar, then the source generation will throw a zip exception and abort the build. The plugin should guard against this and issue a warning instead of failing.

      A patch with the guard will be attached.

        Activity

        Hide
        laphroaig15 Jess added a comment -

        Simple guard against zero length source jars.

        Show
        laphroaig15 Jess added a comment - Simple guard against zero length source jars.
        Hide
        rfscholte Robert Scholte added a comment -

        Fixed in 1805504
        Thanks for the patch!

        Show
        rfscholte Robert Scholte added a comment - Fixed in 1805504 Thanks for the patch!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #9072 (See https://builds.apache.org/job/maven-plugins/9072/)
        MSHADE-257 Bad zero length source jars published by 3rd parties cause source jar creation to fail. (rfscholte: http://svn.apache.org/viewvc/?view=rev&rev=1805504)

        • (edit) maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #9072 (See https://builds.apache.org/job/maven-plugins/9072/ ) MSHADE-257 Bad zero length source jars published by 3rd parties cause source jar creation to fail. (rfscholte: http://svn.apache.org/viewvc/?view=rev&rev=1805504 ) (edit) maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java

          People

          • Assignee:
            rfscholte Robert Scholte
            Reporter:
            laphroaig15 Jess
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development