MRUnit
  1. MRUnit
  2. MRUNIT-76

Why are the mapred test classes under o.a.h.mrunit instead of o.a.h.mrunit.mapred?

    Details

    • Type: Question Question
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 0.8.1
    • Fix Version/s: None
    • Labels:
      None

      Description

      Why are the mapred test classes under o.a.h.mrunit instead of o.a.h.mrunit.mapred?

        Activity

        Hide
        Jim Donofrio added a comment -

        Leave packaging as it is because eventually entire current API will be deprecated in favor of work in MRUNIT-69

        Show
        Jim Donofrio added a comment - Leave packaging as it is because eventually entire current API will be deprecated in favor of work in MRUNIT-69
        Hide
        Jim Donofrio added a comment -

        I guess those simple classes would have to maintain full API compatibility. We probably should leave it as it is until we implement some of the major changes in MRUNIT-69 which will break compatibility anyway.

        Show
        Jim Donofrio added a comment - I guess those simple classes would have to maintain full API compatibility. We probably should leave it as it is until we implement some of the major changes in MRUNIT-69 which will break compatibility anyway.
        Hide
        Jarek Jarcec Cecho added a comment -

        Or we can do something in between. We can create new module o.a.h.mrunit.mapred, move all mapred related classes there and create new very simple classes in o.a.h.mrunit that will simply inherit from o.a.h.mrunit.mapred (without any additional logic) for backward compatibility (+ marking them as deprecated). I believe that it would be clean to remove those simple classes after couple of releases.

        Show
        Jarek Jarcec Cecho added a comment - Or we can do something in between. We can create new module o.a.h.mrunit.mapred, move all mapred related classes there and create new very simple classes in o.a.h.mrunit that will simply inherit from o.a.h.mrunit.mapred (without any additional logic) for backward compatibility (+ marking them as deprecated). I believe that it would be clean to remove those simple classes after couple of releases.
        Hide
        Brock Noland added a comment -

        Agreed, seems odd, my guess is that it mrunit was created before they realized there was going to be a mapred and mapreduce package. I like neat boxes so i thought about proposing a rename of the classes but it'd be a fairly large breaking change which I dislike more than neat boxes...

        Show
        Brock Noland added a comment - Agreed, seems odd, my guess is that it mrunit was created before they realized there was going to be a mapred and mapreduce package. I like neat boxes so i thought about proposing a rename of the classes but it'd be a fairly large breaking change which I dislike more than neat boxes...

          People

          • Assignee:
            Jim Donofrio
            Reporter:
            Jim Donofrio
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development