[MRUNIT-116] Setting of configuration on Mappers/Reducers in MapDriver and ReduceDriver is inconsistent

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.0
• Assignee: Dave Beech
• Reporter: Dave Beech
• Created: 09/Jun/12 12:23
• Updated: 10/Jul/12 22:17
• Resolved: 09/Jun/12 14:23

Description

In the run methods of MapDriver and ReduceDriver (mapred API), the calling of setConf and configure is inconsistent.

The check for instanceof Configurable and the call to setConf is missing from ReduceDriver.

I suggest we replace these configuration checks and sets with a call to Hadoop's ReflectionUtils.setConf, since this method contains the logic to decide what to set where, based on whether the object is Configurable or JobConfigurable etc. It also handles the proposed deprecation of JobConf, so we wouldn't have to worry about that later.

Unless anybody has objections, I'll commit this change.