[MRM-1434] Suspicious RepositoryMetadataMerge.clonePlugins

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: Backlog
• Assignee: Maria Odea B. Ching
• Reporter: David Brosius
• Created: 26/Nov/10 19:09
• Updated: 07/Aug/14 23:42

Description

The method RepositoryMetadataMerge.clonePlugins seems oddly wrong to me, it clones a plugin, but then doesn't use the clone, but uses the original

private static List<Plugin> clonePlugins(List<Plugin> plugins)
{
if (plugins == null)

{ return null; }

List<Plugin> result = new ArrayList<Plugin>();

for (Plugin plugin : plugins)

{ Plugin clonedPlugin = new Plugin(); clonedPlugin.setArtifactId(plugin.getArtifactId()); clonedPlugin.setName(plugin.getName()); clonedPlugin.setPrefix(plugin.getPrefix()); result.add(plugin); <======= should this be clonedPlugin ? }

return result;
}