Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.5
    • Fix Version/s: backlog
    • Component/s: None
    • Labels:
      None

      Description

      Scenario: project with some kind resource affected to the project properties. If some property renamed then resource will contains placeholder instead of actual value. It will be great to have configuration option like 'Fails if property missing'.

        Issue Links

          Activity

          Hide
          Rowan Seymour added a comment -

          I find it hard to imagine a scenario where placeholders with incorrect properties being silently left unfiltered would be desired behaviour. Why has no-one commented on this in two years?

          Show
          Rowan Seymour added a comment - I find it hard to imagine a scenario where placeholders with incorrect properties being silently left unfiltered would be desired behaviour. Why has no-one commented on this in two years?
          Hide
          Gerrie Kimpen added a comment -

          It indeed is an important safety net feature.

          Looking around, I came across this Stackoverflow question Maven warn or fail goal when resource filtering cannot find a property. I added my 2 cents by referring to MRESOURCES-162 and MRESOURCES-163. Hopefully this feature pops up on the radar again.

          Show
          Gerrie Kimpen added a comment - It indeed is an important safety net feature. Looking around, I came across this Stackoverflow question Maven warn or fail goal when resource filtering cannot find a property . I added my 2 cents by referring to MRESOURCES-162 and MRESOURCES-163 . Hopefully this feature pops up on the radar again.
          Hide
          Jörg Hohwiller added a comment -

          I find it hard to imagine a scenario where placeholders with incorrect properties being silently left unfiltered would be desired behaviour.

          There are placed where you might want to have this. E.g. by default variable expressions are written as $

          {property.name}

          and the same syntax is also used by other tools (bash script, etc.). So it might be desired that a variable is not replaced that is later resolved by an interpreter of the outcome.
          However, in such case it is always better and more clean to change the delimited (e.g. to $[*]) in order to avoid confusion.
          Then in about all reasonable case the current behaviour is undesired.
          If this would be implemented the current behaviour should be kept to avoid regression bugs. Instead a new config option should be added to resources plugin that can be enabled to fail on unresolved property.

          Show
          Jörg Hohwiller added a comment - I find it hard to imagine a scenario where placeholders with incorrect properties being silently left unfiltered would be desired behaviour. There are placed where you might want to have this. E.g. by default variable expressions are written as $ {property.name} and the same syntax is also used by other tools (bash script, etc.). So it might be desired that a variable is not replaced that is later resolved by an interpreter of the outcome. However, in such case it is always better and more clean to change the delimited (e.g. to $ [*] ) in order to avoid confusion. Then in about all reasonable case the current behaviour is undesired. If this would be implemented the current behaviour should be kept to avoid regression bugs. Instead a new config option should be added to resources plugin that can be enabled to fail on unresolved property.

            People

            • Assignee:
              Unassigned
              Reporter:
              Alexey Markevich
            • Votes:
              5 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development