[MRESOLVER-241] Resolver checksum calculation should be driven by layout

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: Resolver
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 22/Feb/22 08:13
• Updated: 23/Jul/22 19:04
• Resolved: 15/Mar/22 13:12

Description

Currently, whether connector calculates checksums or not is driven by Layout.ChecksumLocation, but this is wrong, as some artifacts (like signatures) may not have checksum locations returned by layout, and hence, is shutting down complete checksum calculation. That, on the other hand, fails remote transport in case of FAIL checksum policy.
This change alone does NOT fix special cases like "resolving from remote signature", but makes a step to fix it.

The fact that Layout.ChecksumLocation is empty does not mean anything else, that resolver should not expect on remote checksum (REMOTE_EXTERNAL), but not shut down completely checksum validation as other mechanisms (REMOTE_INCLUDED or PROVIDED) should still kick in, if applicable.

Issue Links

• causes: MRESOLVER-236 Make it possible to resolve .asc on a 'fail' <checksumPolicy/> respository.
• links to: GitHub Pull Request #154