[MRESOLVER-157] Get rid of ServiceLocator in Resolver

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-1, 2.0.0
• Component/s: Resolver
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 07/Jan/21 11:12
• Updated: 10/Nov/23 12:42
• Resolved: 15/Oct/23 16:01

Description

maven-resolver currently supports:

• ServiceLocator (deprecated as of 1.7.0 see MRESOLVER-160)
• "vanilla" Guice (provides a module)
• DI using Sisu, as used in Maven

IMO, it makes not much sense to support 3 vastly different "DI"s (in quotes as ServiceLocator is really just a dumb factory pattern).

Not only just complicates the code base, makes changes error prone at least, yields for "exceptions" (this or that will never work with it, as seen with SyncContext), and, for me most importantly, prevents proper constructor initialization and validation of components.

Issue Links

• relates to: MRESOLVER-387 Provide "static" supplier for RepositorySystem
• relates to: MRESOLVER-169 Drop use of ServiceLocator
• relates to: MRESOLVER-386 Make all injected ctors public, deprecate all def ctors
• relates to: MRESOLVER-411 Update to Maven 4.0.0-alpha-8
• links to: GitHub Pull Request #88
• links to: GitHub Pull Request #340