[MRELEASE-989] prepare-with-pom - Cannot add release POM to SCM - API regression

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Affects Version/s: 2.5.3
• Component/s: prepare-with-pom, scm, Subversion

Environment

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
Maven home: D:\maven\apache-maven-3.5.0\bin\..
Java version: 1.8.0_60, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_60\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"


 Included: org.apache.maven.plugins:maven-release-plugin:jar:2.5.3
 Included: com.google.code.maven-scm-provider-svnjava:maven-scm-provider-svnjava:jar:2.1.1
 Included: org.apache.maven.scm:maven-scm-provider-svn-commons:jar:1.8
 Included: net.java.dev.jna:jna:jar:3.5.2
 Included: commons-lang:commons-lang:jar:2.6
 Included: commons-io:commons-io:jar:2.1
 Included: org.tmatesoft.svnkit:svnkit:jar:1.8.7
 Included: com.jcraft:jsch.agentproxy.svnkit-trilead-ssh2:jar:0.0.7
 Included: com.jcraft:jsch.agentproxy.core:jar:0.0.7

• Assignee: Unassigned
• Reporter: Georg Tsakumagos
• Created: 25/Sep/17 12:54
• Updated: 26/Sep/17 10:29

Description

Preparing a prepare-with-pom fails due to the changed SCM API.

The ScmFileSet constructor needs a base path and a list of relative file paths. The release plugin provides a full qualified path. The SCM concat the full qualified path to the basepath and is not able to locate the file. The path should be relative as described in JavaDoc.

May the problem arise to some svn scm implementation which interprets the JavaDoc to precise. But hey thats the reason someone writes javadoc. The constructor org.apache.maven.scm.ScmFileSet.ScmFileSet(File, List<File>) should check the restriction and fail fast.