Uploaded image for project: 'Maven Release Plugin'
  1. Maven Release Plugin
  2. MRELEASE-97

make release:perform upload progress overwrite the previous xxK/yyK uploaded line

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0-beta-4
    • 2.3
    • prepare
    • None
    • maven 2.0.4, head versions of all plugins, win xp, sun jdk 1.5.0_06
    • Patch

    Description

      The current CommandLineUtils.executeCommandLine() in plexus-utils uses the StreamPumper class to copy the output of the 'mvn deploy' call. Because this class is line based, it cannot distinguish between a standard newline and a '\r'. Because of this the upload progress doesn't overwrite itself as the download progress usually does, but writes each step on a new line (see MRELEASE-55).

      I've created 2 patches, one for the release-plugin itself and one for plexus-utils. I'm submitting the plexus-utils patch here as well, because of the direct relation with this report.

      To test, replace the plexus-utils-1.1.jar in <m2_home>/core with the newly built plexus-utils-1.2-SNAPSHOT.jar. After this, import the web project in ReleaseTestWEB.zip into CVS and update the scm url in the pom. Perform a release:prepare and release:perform and verify that the upload counter stays on the same line.

      Attachments

        1. ReleaseTestWEB.zip
          2 kB
          Marcel Schutte
        2. plexus-utils.diff
          8 kB
          Marcel Schutte
        3. maven-release-plugin.diff
          8 kB
          Marcel Schutte

        Issue Links

          Activity

            People

              rfscholte Robert Scholte
              mschutte Marcel Schutte
              Votes:
              4 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: