[MRELEASE-871] Release Tag wrongly created when invoked pom.xml path contains a '.'

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.5.2
• Component/s: perform, scm
• Environment: RHEL Linux, Windows 7, most probably others
• Flags: Patch
• Assignee: Robert Scholte
• Reporter: Gertjan Gaillet
• Created: 02/Apr/14 08:04
• Updated: 05/Apr/15 14:54
• Resolved: 29/Mar/15 16:58

Description

Issue
When invoking the maven release plugin on a pom.xml referenced by a path including a '.', the release tag created is incorrect.

Example: mvn clean release:clean release:prepare release:perform [options] -f ./pom.xml

This is true for both modular and hierarchical projects:

/parent-pom/pom.xml
/module-a/pom.xml
/module-b/pom.xml

and

/pom.xml <-- this is the parent pom
/module-a/pom.xml
/module-b/pom.xml

When releasing projects with either structure, invoking maven with "-f ./parent-pom/pom.xml" and "-f ./pom.xml" respectively, the tag operation copies from one level too high. For example if the svn structure is as follows:

/trunk (at v 1.0.0-SNAPSHOT)
/branches/project-0.1.x (at v 0.1.0-SNAPSHOT)
/branches/project-0.2.x (at v 0.2.0-SNAPSHOT)
/tags/project-0.1.0

and a release is being made from trunk, the tag project-1.0.0 would contain the complete svn structure. When a release is being made from /branches/project-0.1.x, the tag project-0.1.0 would contain the two branches:

/branches/project-0.1.x
/branches/project-0.2.x

Root cause
After some debugging, I've found that the issue is caused by function getBaseWorkingDirectoryParentCount in org.apache.maven.shared.release.util.ReleaseUtil.

I've created a patch (for trunk and 2.5), as attached, and tested it successfully on Windows7 and RHEL, with jdk1.6.0_26 and maven 3.0.4.
Let me know if the patch is OK (we are currently using it without any issue, and resolving this bug) and I'll commit it accordingly.