[MRELEASE-386] Sneaky bug in DefaultReleaseManager.perform()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0-beta-8
• Fix Version/s: 2.0-beta-9
• Environment: n/a
• Flags: Patch
• Assignee: Arnaud Heritier
• Reporter: Anders Hammar
• Created: 12/Nov/08 06:04
• Updated: 05/Apr/15 14:54
• Resolved: 26/Nov/08 15:54

Description

While browsing the code I saw this sneaky bug in DefaultReleaseManager (note that the clean parameter value is ignored):

    public void perform( ReleaseDescriptor releaseDescriptor, ReleaseEnvironment releaseEnvironment, List reactorProjects, boolean clean )
        throws ReleaseExecutionException, ReleaseFailureException
    {
        perform( releaseDescriptor, releaseEnvironment, reactorProjects, null, false );
    }

This method is only used once within the release plugin and it that case the clean parameter value is then always 'false', so this is not yet an issue when using the plugin.