[MPLUGINTESTING-63] AbstractMojoTestCase should return correct type

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Information Provided
• Assignee: Unassigned
• Reporter: Samael Bate
• Created: 11/Aug/19 19:27
• Updated: 17/Jul/21 22:18
• Resolved: 17/Jul/21 22:18

Description

the AbstractMojoTestCase class has numerous methods that simply return Mojo. An exmaple of which would be:

protected Mojo lookupConfiguredMojo( MavenProject project, String goal )
    throws Exception
{
    return lookupConfiguredMojo( newMavenSession( project ), newMojoExecution( goal ) );
}

 

It would be to deprecate these methods and replace them with typed equivelant, so the aboce would become:

protected <T extends Mojo> T lookupConfiguredMojo( MavenProject project, Class<T> type )

as noted by rfscholte on github PR 8, the name of the goal could be obtained from the Mojo's annotation