Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.6.2
    • None
    • None

    Description

      Its look like Mojo params:
       

      • executionStrategy 
      • requiresDirectInvocation
      • inheritByDefault  (PluginDescriptorBuilder - use only inheritedByDefault)

       

      are not used currently, I was looking in 3.8.x and master branch.

      Flags should be deprecated or removed.

      Attachments

        Activity

          IMHO, deprecate for start by adding @deprecated unused Javadoc along with @Deprecated annotation.

          cstamas Tamas Cservenak added a comment - IMHO, deprecate for start by adding @deprecated unused  Javadoc along with @Deprecated annotation.
          sbernard Simon added a comment -

          I have a mojo which is using `inheritByDefault=false` annotation param and it seems this has no effect (or at least not the effect I expect)
          See more details.

          Is it relative to this issue ?
          Is it a bug or is it expected ?
          Is there a way (or a workaround) to make my mojo not inherited by default ?

          thanks 🙏

          sbernard Simon added a comment - I have a mojo which is using `inheritByDefault=false` annotation param and it seems this has no effect (or at least not the effect I expect) See more details . Is it relative to this issue ? Is it a bug or is it expected ? Is there a way (or a workaround) to make my mojo not inherited by default ? thanks 🙏

          Correct, these params are not used in maven 3.8.x or 4.x. What you want is as you figured: <inherited>false</inherited> and it does the job: executes only at top level as your Mojo is aggregator.

          cstamas Tamas Cservenak added a comment - Correct, these params are not used in maven 3.8.x or 4.x. What you want is as you figured: <inherited>false</inherited> and it does the job: executes only at top level as your Mojo is aggregator.
          sbernard Simon added a comment -

          Just to be sure I get you correctly, with recent version of maven there is no way to create the mojo in a way that Users does not need to add manually <inherited>false</inherited> ?

          I'm curious, do you know why this feature was removed ?
          I guess the documentation should be updated too ? (Unless maybe I looked at a deprecated one)

          sbernard Simon added a comment - Just to be sure I get you correctly, with recent version of maven there is no way to create the mojo in a way that Users does not need to add manually <inherited>false</inherited> ? I'm curious, do you know why this feature was removed ? I guess the documentation should be updated too ? (Unless maybe I looked at a deprecated one)
          cstamas Tamas Cservenak added a comment - - edited

          Truth is, am unsure when was it added in the first place, as in whole git history all I see (might missed) is addition of these fields, but nothing about using them.

          See commit 239439bb043675c07734a55d6313cf4f78e024c9

          Also, this commit is for Maven2, is NOT Maven3! And Maven3 did drop a lot of burden (at cost of loss of some edge case functionalities).

          cstamas Tamas Cservenak added a comment - - edited Truth is, am unsure when was it added in the first place, as in whole git history all I see (might missed) is addition of these fields, but nothing about using them . See commit 239439bb043675c07734a55d6313cf4f78e024c9 Also, this commit is for Maven2, is NOT Maven3! And Maven3 did drop a lot of burden (at cost of loss of some edge case functionalities).
          sbernard Simon added a comment -

          Thx a lot for this clarification. 🙏

          I understand that this feature exists in Maven2 but probably no more in Maven3.

          Maybe there is good reasons to remove it.
          If there are some hesitation, our user feedback is that In our case this could have been a useful feature. (I talk about inheritByDefault=false at mojo level)

          sbernard Simon added a comment - Thx a lot for this clarification. 🙏 I understand that this feature exists in Maven2 but probably no more in Maven3. Maybe there is good reasons to remove it. If there are some hesitation, our user feedback is that In our case this could have been a useful feature. (I talk about inheritByDefault=false at mojo level)

          I kinda vaguely remember something about this: to allow/use this info in Mojo, that would mean that you need to resolve first all the plugins to be able to build effective model.... or something alike, which sounds wrong. Anyone else?

          cstamas Tamas Cservenak added a comment - I kinda vaguely remember something about this: to allow/use this info in Mojo , that would mean that you need to resolve first all the plugins to be able to build effective model.... or something alike, which sounds wrong. Anyone else?

          People

            cstamas Tamas Cservenak
            sjaranowski Slawomir Jaranowski
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: