[MODPYTHON-211] Potential memory leak in req.readlines().

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.3.x, 3.2.10
• Component/s: core
• Assignee: Unassigned
• Reporter: Graham Phillip Dumpleton
• Created: 14/Jan/07 04:02
• Updated: 16/Jul/08 05:32

Description

This code in req.readlines() looks a bit fishy to me and possibly leaks memory. The code in question is:

rlargs = PyTuple_New(0);
if (result == NULL)
return PyErr_NoMemory();

line = req_readline(self, rlargs);
while (line && ((linesize=PyString_Size(line))>0))

{ PyList_Append(result, line); size += linesize; if ((sizehint != -1) && (size >= sizehint)) break; Py_DECREF(line); line = req_readline(self, args); }

Py_XDECREF(line);

The thing that looks wrong is 'rlargs'. This is created, used in a sub call to req_readline() but then never destroyed. Thus, possibly a memory leak.