Maven
  1. Maven
  2. MNG-830

review plugins use of expression and change to default-value/component where appropriate

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.5
    • Component/s: None
    • Labels:
      None

      Description

      we also need a good explanation written down of the difference.

      • default-value is used when expression is null
      • expression is intended to be used to get the user's override, eg from a system property

      Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

      1. MNG-830.patch
        0.8 kB
        Allan Ramirez

        Activity

        Brett Porter created issue -
        Brett Porter made changes -
        Field Original Value New Value
        Fix Version/s 2.0-beta-3 [ 12015 ]
        Fix Version/s 2.0-beta-2 [ 11861 ]
        Brett Porter made changes -
        Fix Version/s 2.0-beta-3 [ 12015 ]
        Fix Version/s 2.0-beta-4 [ 11991 ]
        Brett Porter made changes -
        Component/s maven-plugins [ 11380 ]
        Allan Ramirez made changes -
        Assignee allan ramirez [ aramirez ]
        Allan Ramirez made changes -
        Original Estimate 2h [ 7200 ]
        Remaining Estimate 2h [ 7200 ]
        Allan Ramirez made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Allan Ramirez added a comment -

        From the clover plugin, I found the usage of expression to be
        /**

        • @parameter expression=""
          */
          private String licenseFile;

        Since expression value is null, I removed the expression word to be like this
        /**

        • @parameter
          */
          private String licenseFile;
        Show
        Allan Ramirez added a comment - From the clover plugin, I found the usage of expression to be /** @parameter expression="" */ private String licenseFile; Since expression value is null, I removed the expression word to be like this /** @parameter */ private String licenseFile;
        Allan Ramirez made changes -
        Attachment MNG-830.patch [ 16961 ]
        Allan Ramirez made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Allan Ramirez logged work - 10/Oct/05 02:50
        • Time Spent:
          2h 20m
           
          <No comment>
        Allan Ramirez made changes -
        Remaining Estimate 2h [ 7200 ] 0h [ 0 ]
        Time Spent 2h 20m [ 8400 ]
        Hide
        Brett Porter added a comment -

        applied patch

        Show
        Brett Porter added a comment - applied patch
        John Casey made changes -
        Fix Version/s 2.0.2 [ 12107 ]
        Fix Version/s 2.0.1 [ 12000 ]
        Vincent Massol made changes -
        Workflow Maven [ 39211 ] Maven New [ 48168 ]
        John Casey made changes -
        Fix Version/s 2.0.4 [ 12294 ]
        Fix Version/s 2.0.3 [ 12107 ]
        kenneyw made changes -
        Fix Version/s 2.0.6 [ 13010 ]
        Fix Version/s 2.0.5 [ 12294 ]
        Hide
        Siveton Vincent added a comment -

        Patch already applied (r312878)

        Show
        Siveton Vincent added a comment - Patch already applied (r312878)
        Siveton Vincent made changes -
        Fix Version/s 2.0.5 [ 12294 ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 2.0.6 [ 13010 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:49:45 UTC 2015 [ 1428223785911 ]
        Mark Thomas made changes -
        Workflow jira [ 12712102 ] Default workflow, editable Closed status [ 12752009 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:45:26 UTC 2015 [ 1428270326204 ]
        Mark Thomas made changes -
        Workflow jira [ 12949330 ] Default workflow, editable Closed status [ 12988626 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        36d 20h 12m 1 Allan Ramirez 09/Oct/05 23:52
        In Progress In Progress Open Open
        2h 51m 1 Allan Ramirez 10/Oct/05 02:44
        Open Open Closed Closed
        392d 6h 44m 1 Siveton Vincent 06/Nov/06 08:28

          People

          • Assignee:
            Allan Ramirez
            Reporter:
            Brett Porter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 2h 20m
              2h 20m

                Development