[MNG-7401] Make MavenSession#getCurrentProject() using a thread local

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.9.0, 4.0.0-alpha-2, 4.0.0
• Assignee: Guillaume Nodet
• Reporter: Christoph Läubrich
• Created: 29/Jan/22 10:57
• Updated: 20/Oct/22 08:11
• Resolved: 23/Aug/22 09:20

Description

I noticed that a session is often cloned due to change the current project for a while.

As this works for everyone passing down the session, consumers of the "upper session" (e.g. a SessionScoped Component) would never see this if they are (indirectly) called and e.g. use Session#getCurrentProject().

I wonder if MavenSession could simply use a ThreadLocal for the currentProject (that is shared accross all cloned sessions), that way one would always get the correct value.

Issue Links

• is related to: MNG-7455 [REGRESSION] IllegalStateException in SessionScope during guice injection in multithreaded build
• is required by: MNG-7474 SessionScoped beans should be singletons for a given session
• relates to: MNG-7347 SessionScoped beans should be singletons for a given session
• links to: GitHub Pull Request #666
• links to: GitHub Pull Request #743