[MNG-6991] settings-defined local repository is not honored

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0-alpha-2
• Fix Version/s: 4.0.0-alpha-2, 4.0.0
• Assignee: Maarten Mulders
• Reporter: François Guillot
• Created: 25/Sep/20 06:39
• Updated: 20/Oct/23 07:57
• Resolved: 29/Sep/20 18:37

Description

We have functional tests using the latest Maven snapshots and they started polluting the global ~/.m2/repository.

This commit introduced a bug in the handling of the local repository definition.

The local repository is taken from settings here.

but then, before, Maven was doing (in MavenCli)

        String localRepoProperty = request.getUserProperties().getProperty( MavenCli.LOCAL_REPO_PROPERTY );

        if ( localRepoProperty == null )
        {
            localRepoProperty = request.getSystemProperties().getProperty( MavenCli.LOCAL_REPO_PROPERTY );
        }

        if ( localRepoProperty != null )
        {
            request.setLocalRepositoryPath( localRepoProperty );
        }

effectively replacing the local repository definition only if `maven.repo.local` was defined in user or system properties.
 
After the commit mentioned above, the code does

        request.setLocalRepositoryPath( determineLocalRepositoryPath( request ) );
        ...
        private String determineLocalRepositoryPath( final MavenExecutionRequest request )
        {
            return request.getUserProperties().getProperty(
                    MavenCli.LOCAL_REPO_PROPERTY,
                    request.getSystemProperties().getProperty( MavenCli.LOCAL_REPO_PROPERTY ) // null if not found
            );
        }

effectively always replacing the local repository definition, potentially nulling it.

Issue Links

• links to: GitHub Pull Request #378