[MWRAPPER-20] Maven Wrapper creates empty file when it fails behind proxy 407

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5.6
• Fix Version/s: 3.1.0
• Component/s: Maven Wrapper Scripts
• Environment: Proxy with authentication, http_proxy set without authentication
• Assignee: Herve Boutemy
• Reporter: Benjamin Marwell
• Created: 22/Apr/20 19:57
• Updated: 06/Dec/21 21:27
• Resolved: 05/Dec/21 14:49

Description

Hi,

 

when executing `./mvnw` behind a proxy and the proxy authentication does not succeed, wget will still create an empty file .mvn/maven-wrapper.jar.

 

Subsequent calls to ./mvnw will see the existing (but empty) file and maven-wrapper will not attempt to redownload it. There is no clue what is going wrong, the only message is "Main class not found".

 

Suggested fixes:

• Check curl/wget return codes and delete the files if they got touched.
• Even if curl/wget were not invoked, delete empty files.

Issue Links

• links to: GitHub Pull Request #359