Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5577 Convert the core to use JSR 330 and remove the use of Plexus
  3. MNG-6898

Convert DefaultLifecyclePluginAnalyzer to JSR 330

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.6.3
    • 4.0.0-alpha-2, 4.0.0
    • Core
    • None

    Description

      Convert DefaultLifecyclePluginAnalyzer in maven-core to JSR 330 annotations. This follows on from MNG-5577, which converted the other classes.

      The complication here is that, with the annotations changed, the lifecycleMappings Map is no longer getting filtered by sisu.plexus's RealmFilteredBeans. That means extensions added in one module will appear in all of them, which makes MavenITmng4385LifecycleMappingFromExtensionInReactorTest fail.

      From what I can see, the only place a RealmFilteredBeans is used during injection is when the resource is located through DefaultPlexusBeanLocator. However, that's not the case after that field switches from @Requirement to @Inject.

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. MNG-5577 Convert the core to use JSR 330 and remove the use of Plexus

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #548

          Web Link GitHub Pull Request #554

          Activity

            People

              cstamas Tamas Cservenak
              joe@kafsemo.org Joseph Walton
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: