Maven
  1. Maven
  2. MNG-655

don't load extensions into the main container

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.5
    • Component/s: Plugins and Lifecycle
    • Labels:
      None

      Description

      this should be done on a project by project basis - currently, they are all loaded into the main container.

        Activity

        Brett Porter created issue -
        Vincent Massol made changes -
        Field Original Value New Value
        Workflow jira [ 36343 ] Maven [ 36912 ]
        Brett Porter made changes -
        Component/s maven-core [ 11340 ]
        Brett Porter made changes -
        Fix Version/s 2.0-beta-3 [ 12015 ]
        Fix Version/s 2.0-beta-2 [ 11861 ]
        John Casey made changes -
        Assignee John Casey [ jdcasey ]
        Hide
        John Casey added a comment -

        I'd like to make a full-fledged extension manager, and create a separate classloader/realm/container/whatever for extensions per-project inside that extension manager...this way, we can reuse the extensions approach to augmenting the build system for other things in the future...like maybe custom conflict resolution strategies, etc.

        Show
        John Casey added a comment - I'd like to make a full-fledged extension manager, and create a separate classloader/realm/container/whatever for extensions per-project inside that extension manager...this way, we can reuse the extensions approach to augmenting the build system for other things in the future...like maybe custom conflict resolution strategies, etc.
        John Casey made changes -
        Complexity Expert
        Original Estimate 4h [ 14400 ]
        Remaining Estimate 4h [ 14400 ]
        Hide
        Brett Porter added a comment -

        do you think that this should be held over for 2.1?

        Show
        Brett Porter added a comment - do you think that this should be held over for 2.1?
        Hide
        John Casey added a comment -

        this needs to wait for 2.1, yes. it'll be hard to avoid problems with Class.forName() when we do this...it almost implies that we'll need a fresh plugin container for each plugin/project, so that the extensions container created for the project can be the parent of the plugin container. I know you can setParent(..), but that won't work if the plugin is holding references to components in a Map or something.

        Show
        John Casey added a comment - this needs to wait for 2.1, yes. it'll be hard to avoid problems with Class.forName() when we do this...it almost implies that we'll need a fresh plugin container for each plugin/project, so that the extensions container created for the project can be the parent of the plugin container. I know you can setParent(..), but that won't work if the plugin is holding references to components in a Map or something.
        John Casey made changes -
        Remaining Estimate 4h [ 14400 ] 8h [ 28800 ]
        Fix Version/s 2.1 [ 11704 ]
        Fix Version/s 2.0-beta-3 [ 12015 ]
        Original Estimate 4h [ 14400 ] 8h [ 28800 ]
        Vincent Massol made changes -
        Workflow Maven [ 36912 ] Maven New [ 46966 ]
        John Casey made changes -
        Assignee John Casey [ jdcasey ]
        Jason van Zyl made changes -
        Fix Version/s 2.1.x [ 13142 ]
        Fix Version/s 2.1 [ 11704 ]
        Hide
        Jason van Zyl added a comment -

        Not the case in either the branch or the trunk any longer.

        Show
        Jason van Zyl added a comment - Not the case in either the branch or the trunk any longer.
        Jason van Zyl made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Brett Porter made changes -
        Fix Version/s 2.1.x [ 13142 ]
        Fix Version/s 2.0.5 [ 12294 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:49:45 UTC 2015 [ 1428223785911 ]
        Mark Thomas made changes -
        Workflow jira [ 12711965 ] Default workflow, editable Closed status [ 12751293 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:45:26 UTC 2015 [ 1428270326204 ]
        Mark Thomas made changes -
        Workflow jira [ 12948713 ] Default workflow, editable Closed status [ 12987967 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        677d 22h 53m 1 Jason van Zyl 05/Jun/07 00:36

          People

          • Assignee:
            Unassigned
            Reporter:
            Brett Porter
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 8h
              8h
              Remaining:
              Remaining Estimate - 8h
              8h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development