[MNG-6435] DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.5.3
• Fix Version/s: Issues to be reviewed for 4.x
• Component/s: Settings
• Assignee: Unassigned
• Reporter: Laird Nelson
• Created: 27/Jun/18 22:04
• Updated: 29/Mar/23 18:44

Description

On or around line 234, interpolation of settings assumes XML:

interpolator.addPostProcessor( new InterpolationPostProcessor()
{
  @Override
  public Object execute( String expression, Object value )
  {
    if ( value != null )
    {
      // we're going to parse this back in as XML so we need to escape XML markup
      value = value.toString().replace( "&", "&amp;" ).replace( "<", "&lt;" ).replace( ">", "&gt;" );
      return value;
    }
    return null;
  }
} );

The value being interpolated here is the result of a SettingsWriter's output. Obviously this kind of escaping doesn't make any sense if the SettingsWriter in question is not XML-based.

Issue Links

• relates to: MSITE-933 mvn site fails when <name> contains &amp;