[MNG-6414] Add more Apache license header patterns to skip downloading Apache license

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.1, 3.3.9, 3.5.4
• Fix Version/s: 3.6.0
• Assignee: Sylwester Lachiewicz
• Reporter: Sylwester Lachiewicz
• Created: 22/May/18 06:01
• Updated: 28/Mar/20 15:02
• Resolved: 16/Sep/18 13:56

Description

While preparing Maven distribution, maven-remote-resources-plugin uses appended-resources/META-INF/LICENSE.vm to add content to LICENSE and try to download licenses for all dependencies that are not Apache licensed (see end of LICENSE and resulting lib/*.license in Maven binary distribution, since Maven 3.2.1 MNG-5494).

License file is not downloaded only when project/license/name is strictly equal to "The Apache Software License, Version 2.0": this is too restrictive, as we see Apache license downloaded many times from https://www.apache.org/ (causing some issues with https: MNG-6358). 

After debugging these cases, additional patterns for Apache license exist and need to be added to exception list in appended-resources/META-INF/LICENSE.vm:

• "Apache License, Version 2.0"
• "The Apache Software License, Version 2.0"
• "ASLv2"
• "Apache Public License 2.0"

 

Issue Links

• is caused by: MNG-5494 Add a license file that corresponds to each GAV in the distribution
• is related to: MNG-6358 Maven build should not require access to apache.org
• links to: GitHub Pull Request #167