Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6296

New option -Dstyle.color is not working

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.2
    • Fix Version/s: 3.5.3
    • Component/s: None
    • Labels:
      None

      Description

      The new option -Dstyle.color=(auto|always|never) is not working. This happens as the corresponding code accesses the UserProperties of the CliRequest before they are set. I'll provide a quick fix for this by changing the order of the methods in the doMain method so the properties will be set at the right time.
      But I'd suggest to refactor the whole stuff so the code will become easier to understand and maintain. IMHO the functionality of the properties method in the MavenCli should be moved to the constructor of the CliRequest. The CliRequest itself should be immutable so all fields will have the correct content all the time.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rfscholte Robert Scholte
                Reporter:
                coder-hugo Robin Müller
              • Votes:
                4 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: