[MNG-6296] New option -Dstyle.color is not working

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.2
• Fix Version/s: 3.5.3
• Assignee: Robert Scholte
• Reporter: Robin Müller
• Created: 26/Oct/17 07:54
• Updated: 28/Mar/20 15:01
• Resolved: 21/Nov/17 22:36

Description

The new option -Dstyle.color=(auto|always|never) is not working. This happens as the corresponding code accesses the UserProperties of the CliRequest before they are set. I'll provide a quick fix for this by changing the order of the methods in the doMain method so the properties will be set at the right time.
But I'd suggest to refactor the whole stuff so the code will become easier to understand and maintain. IMHO the functionality of the properties method in the MavenCli should be moved to the constructor of the CliRequest. The CliRequest itself should be immutable so all fields will have the correct content all the time.

Issue Links

• breaks: MNG-6220 Add CLI options to control color output
• incorporates: MNG-5835 Maven-Plugin's getLog() ignores -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
• is related to: MNG-6241 colour output cannot be disabled from settings.xml or MAVEN_OPTS
• relates to: MNG-6380 Option -Dstyle.color=always doesn't force color output
• links to: GitHub Pull Request #135
• links to: GitHub Pull Request #135