[MNG-6228] Optionality not displayed in dependency tree when run in debug mode

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.2
• Component/s: Dependencies, Logging
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 09/May/17 19:35
• Updated: 28/Mar/20 15:01
• Resolved: 10/May/17 07:10

Description

Consider you have optional dependencies in your POM and run Maven with -X, you'll see:

[DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=0, ConflictMarker.markTime=1, ConflictMarker.nodeCount=6, ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=1, ConflictIdSorter.conflictIdCount=5, ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2, ConflictResolver.conflictItemCount=5, DefaultDependencyCollector.collectTime=26, DefaultDependencyCollector.transformTime=6}
[DEBUG] org.apache.maven.its.mng5935:test:jar:0.1
[DEBUG]    com.mysema.querydsl:querydsl-core:jar:3.4.3:compile
[DEBUG]       com.google.guava:guava:jar:17.0:compile (version managed from 14.0)
[DEBUG]       com.google.code.findbugs:jsr305:jar:2.0.3:compile (version managed from 1.3.9)
[DEBUG]       com.mysema.commons:mysema-commons-lang:jar:0.2.4:compile
[DEBUG]       com.infradna.tool:bridge-method-annotation:jar:1.13:compile

The optional flag is never displayed. This leads to two issues:

1. It causes confusion with the user
2. The user thinks that the option flag does not work

This required information shall be printed as same as MDEP does: ...(optional)

The expected result would be:

[DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=0, ConflictMarker.markTime=1, ConflictMarker.nodeCount=6, ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=1, ConflictIdSorter.conflictIdCount=5, ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2, ConflictResolver.conflictItemCount=5, DefaultDependencyCollector.collectTime=26, DefaultDependencyCollector.transformTime=6}
[DEBUG] org.apache.maven.its.mng5935:test:jar:0.1
[DEBUG]    com.mysema.querydsl:querydsl-core:jar:3.4.3:compile (optional)
[DEBUG]       com.google.guava:guava:jar:17.0:compile (version managed from 14.0) (optional)
[DEBUG]       com.google.code.findbugs:jsr305:jar:2.0.3:compile (version managed from 1.3.9) (optional)
[DEBUG]       com.mysema.commons:mysema-commons-lang:jar:0.2.4:compile (optional)
[DEBUG]       com.infradna.tool:bridge-method-annotation:jar:1.13:compile (optional)

Issue Links

• is related to: MSHARED-437 maven-dependency-tree removes optional flag from managed dependencies
• relates to: MNG-5935 Optional true getting lost in managed dependencies when transitive
• relates to: MNG-6229 Write out optionality in Core IT Plugins for collection and resolution