[MNG-6030] ReactorModelCache do not used effectively after maven version 3.0.5 which cause a large memory footprint

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1, 3.2.5, 3.3.3, 3.3.9
• Fix Version/s: 3.5.0-alpha-1, 3.5.0
• Component/s: Embedding
• Labels: memory performance
• Assignee: Karl Heinz Marbaise
• Reporter: Andriy
• Created: 30/May/16 16:08
• Updated: 28/Mar/20 15:00
• Resolved: 25/Jan/17 20:00

Description

after version 3.0.5 we found a very big memory consumption with maven. needed for build memory grows from 1G to 5G

According to current implementation there were change with commit https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=e778ea67121f17232a7dced3fb4f0a205ffa64af
https://issues.apache.org/jira/browse/MNG-5312

private ModelBuildingRequest getModelBuildingRequest( InternalConfig config )
    {
@@ -256,7 +256,7 @@ public class DefaultProjectBuilder
         request.setUserProperties( configuration.getUserProperties() );
         request.setBuildStartTime( configuration.getBuildStartTime() );
         request.setModelResolver( resolver );
-        request.setModelCache( config.modelCache );
+        request.setModelCache( new ReactorModelCache() );

         return request;
     }

and as result new ReactorModelCache created for each ModelBuildingRequest which is created new to parse each pom.xml included in the build as module.

so if there is a big projects with a lot of modules ModelBuildingRequest is created for each of them and parse result is not reused between modules. and if all this modules has the same parent pom it parsed each time and stored as many times as many ModelBuildingRequest was created. As parent pom often contains dependencies, dependencyManagement and common information for all modules it cause a larger memory footprint then was before. In version 3.0.5 and earlier ReactorModelCache was single and was reused between ModelBuildingRequest.

in our cause footprint grew from 1g to 5g.

it will be better to reuse result of parsing pom files between ModelBuildingRequests.

Issue Links

• breaks: MNG-6330 [regression] Parents relativePath not verified anymore
• is broken by: MNG-5312 MavenProject.getParent intolerably slow when import scope used heavily
• is related to: MNG-6530 Regression in ProjectBuilder when file change between invocations (introduced by MNG-6311)
• mentioned in: Page Loading...