Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5889

.mvn directory should be picked when using --file

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.3.9
    • Fix Version/s: 3.5.0-alpha-1, 3.5.0
    • Component/s: Bootstrap & Build
    • Labels:
      None

      Description

      The .mvn directory is not picked up when using the --file switch to build a project from outside of the multi-module root.

      Example:

      • the module root is /foo/bar
      • .mvn is located at /foo/bar/.mvn
      • current directory is /foo
      • Maven is invoked with mvn --file bar/module/pom.xml

      I would expect the .mvn directory detection to start at the directory of the POM selected by --file and then go through the parent directories.

        Issue Links

          Activity

          Hide
          aheritier Arnaud HERITIER added a comment -

          Hi Daniel,

          It is clearly a bug/limitation of the current implementation and it is really annoying for exemple on CI servers where you can checkout the project in a subdirectory and launch the build with the path to the pom parameter.

          I was aware of this bug for few months but I forgot to report it. I described it to the team on IRC few days ago but I had sadly no feedback.

          Technically I don't yet know how to fix it. The problem is that it enforces at the .sh/.cmd script level to parte the command line options to find if the f/-file option is defined. If it is the case we need to extract its value and compute the path of the module directory (AFAIR we can either pass to the option the module directory or the POM file). When the module directory is found we need to find the .mvn directory from this path and not from the local directory. For the shell .sh version I think I may succeed to propose a fix, but for the windows .cmd I'm less confident and I'm clearly against to have a different behaviour based on the OS

          Show
          aheritier Arnaud HERITIER added a comment - Hi Daniel, It is clearly a bug/limitation of the current implementation and it is really annoying for exemple on CI servers where you can checkout the project in a subdirectory and launch the build with the path to the pom parameter. I was aware of this bug for few months but I forgot to report it. I described it to the team on IRC few days ago but I had sadly no feedback. Technically I don't yet know how to fix it. The problem is that it enforces at the .sh/.cmd script level to parte the command line options to find if the f/ -file option is defined. If it is the case we need to extract its value and compute the path of the module directory (AFAIR we can either pass to the option the module directory or the POM file). When the module directory is found we need to find the .mvn directory from this path and not from the local directory. For the shell .sh version I think I may succeed to propose a fix, but for the windows .cmd I'm less confident and I'm clearly against to have a different behaviour based on the OS
          Hide
          daniel.spilker@hamburg.de Daniel Spilker added a comment -

          Hi Arnaud,

          indeed I was running into this problem when using the Jenkins Maven Plugin.

          It should be possible to add a "base directory" setting to that plugin so that the CI can change to the base directory before launching Maven, but I think it would be better to fix the problem at the root.

          Show
          daniel.spilker@hamburg.de Daniel Spilker added a comment - Hi Arnaud, indeed I was running into this problem when using the Jenkins Maven Plugin . It should be possible to add a "base directory" setting to that plugin so that the CI can change to the base directory before launching Maven, but I think it would be better to fix the problem at the root.
          Hide
          khmarbaise Karl Heinz Marbaise added a comment -

          The problem at the moment is that the shell script (mvn / mvn.cmd) is finding the location of the folder....and not Maven itself...

          Show
          khmarbaise Karl Heinz Marbaise added a comment - The problem at the moment is that the shell script (mvn / mvn.cmd) is finding the location of the folder....and not Maven itself...
          Hide
          aheritier Arnaud HERITIER added a comment -

          Daniel Spilker Yes I discovered the issue within Jenkins too where it is a common need to define the path and to not checkout the project in the root directory of the workspace. Having an option to setup the base directory may be a workaround but I don't find any other usage of it and like you I would prefer to see the problem fixed on Maven side

          Karl Heinz Marbaise yes because of JVM options which have to be discovered before launching Maven

          Show
          aheritier Arnaud HERITIER added a comment - Daniel Spilker Yes I discovered the issue within Jenkins too where it is a common need to define the path and to not checkout the project in the root directory of the workspace. Having an option to setup the base directory may be a workaround but I don't find any other usage of it and like you I would prefer to see the problem fixed on Maven side Karl Heinz Marbaise yes because of JVM options which have to be discovered before launching Maven
          Hide
          rhpatrick00 Robert Patrick added a comment -

          This is easy enough to fix by scanning the command-line arguments in the shell script. I have a fix working for the sh script...still fighting with Windows to get something equivalent working in the cmd script.

          Show
          rhpatrick00 Robert Patrick added a comment - This is easy enough to fix by scanning the command-line arguments in the shell script. I have a fix working for the sh script...still fighting with Windows to get something equivalent working in the cmd script.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rpatrick00 opened a pull request:

          https://github.com/apache/maven/pull/93

          MNG-5889 - adding logic that looks for the file argument and starts t…

          …he search for the .mvn directory at the location of the specified POM when present

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rpatrick00/maven master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven/pull/93.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #93


          commit f2decc7771cdb7a34fcfd150ec4354f9d0a9aa6f
          Author: robert.patrick <robert.patrick@oracle.com>
          Date: 2016-09-06T22:35:07Z

          MNG-5889 - adding logic that looks for the file argument and starts the search for the .mvn directory at the location of the specified POM when present


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rpatrick00 opened a pull request: https://github.com/apache/maven/pull/93 MNG-5889 - adding logic that looks for the file argument and starts t… …he search for the .mvn directory at the location of the specified POM when present You can merge this pull request into a Git repository by running: $ git pull https://github.com/rpatrick00/maven master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit f2decc7771cdb7a34fcfd150ec4354f9d0a9aa6f Author: robert.patrick <robert.patrick@oracle.com> Date: 2016-09-06T22:35:07Z MNG-5889 - adding logic that looks for the file argument and starts the search for the .mvn directory at the location of the specified POM when present
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 closed the pull request at:

          https://github.com/apache/maven/pull/93

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 closed the pull request at: https://github.com/apache/maven/pull/93
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/93

          Fixing a small problem...will resubmit

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Fixing a small problem...will resubmit
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rpatrick00 reopened a pull request:

          https://github.com/apache/maven/pull/93

          MNG-5889 - adding logic that looks for the file argument and starts t…

          …he search for the .mvn directory at the location of the specified POM when present

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rpatrick00/maven master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven/pull/93.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #93


          commit f2decc7771cdb7a34fcfd150ec4354f9d0a9aa6f
          Author: robert.patrick <robert.patrick@oracle.com>
          Date: 2016-09-06T22:35:07Z

          MNG-5889 - adding logic that looks for the file argument and starts the search for the .mvn directory at the location of the specified POM when present

          commit ef1fec23a2d600e5151212a00523e2abe27bacfb
          Author: robert.patrick <robert.patrick@oracle.com>
          Date: 2016-09-06T23:25:47Z

          fixing findBaseDir loop to not include the initial cd /d


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rpatrick00 reopened a pull request: https://github.com/apache/maven/pull/93 MNG-5889 - adding logic that looks for the file argument and starts t… …he search for the .mvn directory at the location of the specified POM when present You can merge this pull request into a Git repository by running: $ git pull https://github.com/rpatrick00/maven master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit f2decc7771cdb7a34fcfd150ec4354f9d0a9aa6f Author: robert.patrick <robert.patrick@oracle.com> Date: 2016-09-06T22:35:07Z MNG-5889 - adding logic that looks for the file argument and starts the search for the .mvn directory at the location of the specified POM when present commit ef1fec23a2d600e5151212a00523e2abe27bacfb Author: robert.patrick <robert.patrick@oracle.com> Date: 2016-09-06T23:25:47Z fixing findBaseDir loop to not include the initial cd /d
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jochenw commented on the issue:

          https://github.com/apache/maven/pull/93

          I wonder, whether this couldn't be handled at the Java level? If so, there would be no need to change script files, making them even more complex than they already are.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jochenw commented on the issue: https://github.com/apache/maven/pull/93 I wonder, whether this couldn't be handled at the Java level? If so, there would be no need to change script files, making them even more complex than they already are.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/93

          Because the maven shell scripts are finding the .mvn directory before starting java in order to find the relevant .mvn/jvm.config to process any java command-line options that may be found in it. This location is passed into the Java process so that the Java code does not look for the .mvn directory again...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Because the maven shell scripts are finding the .mvn directory before starting java in order to find the relevant .mvn/jvm.config to process any java command-line options that may be found in it. This location is passed into the Java process so that the Java code does not look for the .mvn directory again...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jochenw commented on the issue:

          https://github.com/apache/maven/pull/93

          Then possibly a good first step would be to move that logic from the scripts to the Java Main class.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jochenw commented on the issue: https://github.com/apache/maven/pull/93 Then possibly a good first step would be to move that logic from the scripts to the Java Main class.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/93

          Did you not understand what I said?

          .mvn/jvm.config might look like this:

          -Xmx2048m
          -Xms1024m
          -XX:MaxPermSize=512m
          -Djava.awt.headless=true

          If I move the processing of that file into Java, how am I going to set those options on the Java command-line used to start Maven?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Did you not understand what I said? .mvn/jvm.config might look like this: -Xmx2048m -Xms1024m -XX:MaxPermSize=512m -Djava.awt.headless=true If I move the processing of that file into Java, how am I going to set those options on the Java command-line used to start Maven?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/93

          IIUC this might be useful in CI because you may run `mvn deploy -f /path/to/project/pom.xml` and the discovery would be made in `/path/to/project/.mvn` as well. AFAIK Maven is not 2 processes running but one and you need to pass jvm options like this then.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/93 IIUC this might be useful in CI because you may run `mvn deploy -f /path/to/project/pom.xml` and the discovery would be made in `/path/to/project/.mvn` as well. AFAIK Maven is not 2 processes running but one and you need to pass jvm options like this then.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aheritier commented on the issue:

          https://github.com/apache/maven/pull/93

          +1000 for this change (as far as it is tested/validated)
          This problem of using -f on CI servers (and non only) is very common and it makes the usage of .mvn folders useless.
          The problem is to be sure that we are fixing this for linux and windows

          Show
          githubbot ASF GitHub Bot added a comment - Github user aheritier commented on the issue: https://github.com/apache/maven/pull/93 +1000 for this change (as far as it is tested/validated) This problem of using -f on CI servers (and non only) is very common and it makes the usage of .mvn folders useless. The problem is to be sure that we are fixing this for linux and windows
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/93

          I tested this on both Linux and Windows, but most of the testing was on Windows simply because Windows CMD scripts are challenging to get right. The sh script is much simpler...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 I tested this on both Linux and Windows, but most of the testing was on Windows simply because Windows CMD scripts are challenging to get right. The sh script is much simpler...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/93

          I want to test it as well and then push it to master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/93 I want to test it as well and then push it to master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/93

          @rpatrick00 pls squash it to one commit.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/93 @rpatrick00 pls squash it to one commit.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 closed the pull request at:

          https://github.com/apache/maven/pull/93

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 closed the pull request at: https://github.com/apache/maven/pull/93
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rpatrick00 opened a pull request:

          https://github.com/apache/maven/pull/94

          MNG-5889 - adding logic that looks for the file argument and starts t…

          …he search for the .mvn directory at the location of the specified POM when present

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rpatrick00/maven master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven/pull/94.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #94


          commit 15de446618b9cb12158f098ab4889fe61c429bc7
          Author: robert.patrick <robert.patrick@oracle.com>
          Date: 2016-09-15T14:53:06Z

          MNG-5889 - adding logic that looks for the file argument and starts the search for the .mvn directory at the location of the specified POM when present


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rpatrick00 opened a pull request: https://github.com/apache/maven/pull/94 MNG-5889 - adding logic that looks for the file argument and starts t… …he search for the .mvn directory at the location of the specified POM when present You can merge this pull request into a Git repository by running: $ git pull https://github.com/rpatrick00/maven master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit 15de446618b9cb12158f098ab4889fe61c429bc7 Author: robert.patrick <robert.patrick@oracle.com> Date: 2016-09-15T14:53:06Z MNG-5889 - adding logic that looks for the file argument and starts the search for the .mvn directory at the location of the specified POM when present
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/93

          Submitting a new pull request...

          https://github.com/apache/maven/pull/94

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Submitting a new pull request... https://github.com/apache/maven/pull/94
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/93

          @Tibor17, have you looked at the pull request? Any issues with merging it?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 @Tibor17, have you looked at the pull request? Any issues with merging it?
          Hide
          tibor17 Tibor Digana added a comment -

          Sorry, I was quite busy this week. I will merge it in a day.

          Show
          tibor17 Tibor Digana added a comment - Sorry, I was quite busy this week. I will merge it in a day.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/94

          @rpatrick00
          It looks like "--file" is not recognize but "-file" is recognized.
          The second issue where I have `/a/b` folders and `b` contains single `pom.xml` and `.mvn` - no multimodule.
          `cd /a` which does not have `.mvn` and start `mvn -file b/pom.xml`. There my `vm.config` is not applied, why? Tested on Win. I will try in Fedora as well.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @rpatrick00 It looks like "--file" is not recognize but "-file" is recognized. The second issue where I have `/a/b` folders and `b` contains single `pom.xml` and `.mvn` - no multimodule. `cd /a` which does not have `.mvn` and start `mvn -file b/pom.xml`. There my `vm.config` is not applied, why? Tested on Win. I will try in Fedora as well.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          OK, I found and resolved the problem with the --file arg but am not seeing the other problem you describe (see output below). Maybe my fix for the --file arg resolved that one too?

          Here is a stupid little test project that I am using:
          [maven-test.zip](https://github.com/apache/maven/files/518411/maven-test.zip)

          In the root directory of the project, there is a git.diff file that shows the changes I made to the pull request code. I am happy to resubmit the pull request with this change but would prefer to verify that it fixes the issues in your Windows environment first.

          If you run with JDK 8, you will see the warning about ignoring MaxPermSize=128m, which is set in jvm.config:

          D:\temp>mvn --file maven-test\pom.xml verify
          Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
          [INFO] Scanning for projects...
          [INFO]
          [INFO] ------------------------------------------------------------------------
          [INFO] Building maven-config-test 1.0-SNAPSHOT
          [INFO] ------------------------------------------------------------------------
          [INFO]
          [INFO] — echo-maven-plugin:0.3.0:echo (default) @ maven-config-test —
          [INFO]
          [INFO]
          [INFO]
          [INFO]
          [INFO] myproperty = from.maven.config
          [INFO]
          [INFO]
          [INFO]
          [INFO]
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 0.587 s
          [INFO] Finished at: 2016-10-09T11:20:56-05:00
          [INFO] Final Memory: 17M/491M
          [INFO] ------------------------------------------------------------------------

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 OK, I found and resolved the problem with the --file arg but am not seeing the other problem you describe (see output below). Maybe my fix for the --file arg resolved that one too? Here is a stupid little test project that I am using: [maven-test.zip] ( https://github.com/apache/maven/files/518411/maven-test.zip ) In the root directory of the project, there is a git.diff file that shows the changes I made to the pull request code. I am happy to resubmit the pull request with this change but would prefer to verify that it fixes the issues in your Windows environment first. If you run with JDK 8, you will see the warning about ignoring MaxPermSize=128m, which is set in jvm.config: D:\temp>mvn --file maven-test\pom.xml verify Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0 [INFO] Scanning for projects... [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building maven-config-test 1.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] — echo-maven-plugin:0.3.0:echo (default) @ maven-config-test — [INFO] [INFO] [INFO] [INFO] [INFO] myproperty = from.maven.config [INFO] [INFO] [INFO] [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.587 s [INFO] Finished at: 2016-10-09T11:20:56-05:00 [INFO] Final Memory: 17M/491M [INFO] ------------------------------------------------------------------------
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/94

          Don't create a new PR. Just amend the last commit `git commit --amend` and push it again.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 Don't create a new PR. Just amend the last commit `git commit --amend` and push it again.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          Pushed

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 Pushed
          Hide
          michael-o Michael Osipov added a comment - - edited

          Why can't me move this logic to Java code and let the startup scripts to be as dumb as possible?

          Show
          michael-o Michael Osipov added a comment - - edited Why can't me move this logic to Java code and let the startup scripts to be as dumb as possible?
          Hide
          hboutemy Hervé Boutemy added a comment -

          because .mvn/jvm.config content has to be read before launching the JVM: that's the only cause

          Show
          hboutemy Hervé Boutemy added a comment - because .mvn/jvm.config content has to be read before launching the JVM: that's the only cause
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/94

          @rpatrick00
          LGTM
          I have tested the change on Win7 and Fedora23.
          I will merge your PR with master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @rpatrick00 LGTM I have tested the change on Win7 and Fedora23. I will merge your PR with master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on a diff in the pull request:

          https://github.com/apache/maven/pull/94#discussion_r86662937

          — Diff: apache-maven/src/bin/mvn.cmd —
          @@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%*
          set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR%
          if not "%MAVEN_PROJECTBASEDIR%"=="" goto endDetectBaseDir

          -set "EXEC_DIR=%CD%"
          -set "WDIR=%EXEC_DIR%"
          +set EXEC_DIR=%CD%
          +set WDIR=%EXEC_DIR%
          +
          +@REM Look for the --file switch and start the search for the .mvn directory from the specified
          +@REM POM location, if supplied.
          +
          +set FILE_ARG=
          +:arg_loop
          +if "%1" == "-f" (
          + set "FILE_ARG=%2"
          + shift
          + goto process_file_arg
          +)
          +if "%1" == "--file" (
          + set "FILE_ARG=%2"
          + shift
          + goto process_file_arg
          +)
          +@REM If none of the above, skip the argument
          +shift
          +if not "%~1" == "" (
          + goto arg_loop
          +) else (
          + goto findBaseDir
          +)
          +
          +:process_file_arg
          +if "%FILE_ARG%" == "" (
          + goto findBaseDir
          +)
          +call :get_directory_from_file %FILE_ARG%
          +if not exist "%POM_DIR%" (
          — End diff –

          Why is this check not present in the shell script?

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/94#discussion_r86662937 — Diff: apache-maven/src/bin/mvn.cmd — @@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%* set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR% if not "%MAVEN_PROJECTBASEDIR%"=="" goto endDetectBaseDir -set "EXEC_DIR=%CD%" -set "WDIR=%EXEC_DIR%" +set EXEC_DIR=%CD% +set WDIR=%EXEC_DIR% + +@REM Look for the --file switch and start the search for the .mvn directory from the specified +@REM POM location, if supplied. + +set FILE_ARG= +:arg_loop +if "%1" == "-f" ( + set "FILE_ARG=%2" + shift + goto process_file_arg +) +if "%1" == "--file" ( + set "FILE_ARG=%2" + shift + goto process_file_arg +) +@REM If none of the above, skip the argument +shift +if not "%~1" == "" ( + goto arg_loop +) else ( + goto findBaseDir +) + +:process_file_arg +if "%FILE_ARG%" == "" ( + goto findBaseDir +) +call :get_directory_from_file %FILE_ARG% +if not exist "%POM_DIR%" ( — End diff – Why is this check not present in the shell script?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on a diff in the pull request:

          https://github.com/apache/maven/pull/94#discussion_r86667111

          — Diff: apache-maven/src/bin/mvn.cmd —
          @@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%*
          set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR%
          if not "%MAVEN_PROJECTBASEDIR%"=="" goto endDetectBaseDir

          -set "EXEC_DIR=%CD%"
          -set "WDIR=%EXEC_DIR%"
          +set EXEC_DIR=%CD%
          +set WDIR=%EXEC_DIR%
          +
          +@REM Look for the --file switch and start the search for the .mvn directory from the specified
          +@REM POM location, if supplied.
          +
          +set FILE_ARG=
          +:arg_loop
          +if "%1" == "-f" (
          + set "FILE_ARG=%2"
          + shift
          + goto process_file_arg
          +)
          +if "%1" == "--file" (
          + set "FILE_ARG=%2"
          + shift
          + goto process_file_arg
          +)
          +@REM If none of the above, skip the argument
          +shift
          +if not "%~1" == "" (
          + goto arg_loop
          +) else (
          + goto findBaseDir
          +)
          +
          +:process_file_arg
          +if "%FILE_ARG%" == "" (
          + goto findBaseDir
          +)
          +call :get_directory_from_file %FILE_ARG%
          +if not exist "%POM_DIR%" (
          — End diff –

          Like it or not, sh and cmd are different and have different capabilities. In the sh script, we know that the directory exists because of the check for existence of the POM file. I easily can add the POM file existence test to the cmd script and print the same errors if the pom file does not exist.

          In the cmd script, I need to check for the existence of the extracted directory because if, for some reason, the directory extracted doesn't exist (e.g., a bug in the extraction code), the user gets a cryptic error. The same is not true for the sh script.

          I will add the redundant check to the sh script too just for symmetry purposes...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on a diff in the pull request: https://github.com/apache/maven/pull/94#discussion_r86667111 — Diff: apache-maven/src/bin/mvn.cmd — @@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%* set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR% if not "%MAVEN_PROJECTBASEDIR%"=="" goto endDetectBaseDir -set "EXEC_DIR=%CD%" -set "WDIR=%EXEC_DIR%" +set EXEC_DIR=%CD% +set WDIR=%EXEC_DIR% + +@REM Look for the --file switch and start the search for the .mvn directory from the specified +@REM POM location, if supplied. + +set FILE_ARG= +:arg_loop +if "%1" == "-f" ( + set "FILE_ARG=%2" + shift + goto process_file_arg +) +if "%1" == "--file" ( + set "FILE_ARG=%2" + shift + goto process_file_arg +) +@REM If none of the above, skip the argument +shift +if not "%~1" == "" ( + goto arg_loop +) else ( + goto findBaseDir +) + +:process_file_arg +if "%FILE_ARG%" == "" ( + goto findBaseDir +) +call :get_directory_from_file %FILE_ARG% +if not exist "%POM_DIR%" ( — End diff – Like it or not, sh and cmd are different and have different capabilities. In the sh script, we know that the directory exists because of the check for existence of the POM file. I easily can add the POM file existence test to the cmd script and print the same errors if the pom file does not exist. In the cmd script, I need to check for the existence of the extracted directory because if, for some reason, the directory extracted doesn't exist (e.g., a bug in the extraction code), the user gets a cryptic error. The same is not true for the sh script. I will add the redundant check to the sh script too just for symmetry purposes...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on a diff in the pull request:

          https://github.com/apache/maven/pull/94#discussion_r86667117

          — Diff: apache-maven/src/bin/mvn.cmd —
          @@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%*
          set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR%
          if not "%MAVEN_PROJECTBASEDIR%"=="" goto endDetectBaseDir

          -set "EXEC_DIR=%CD%"
          -set "WDIR=%EXEC_DIR%"
          +set EXEC_DIR=%CD%
          +set WDIR=%EXEC_DIR%
          +
          +@REM Look for the --file switch and start the search for the .mvn directory from the specified
          +@REM POM location, if supplied.
          +
          +set FILE_ARG=
          +:arg_loop
          +if "%1" == "-f" (
          + set "FILE_ARG=%2"
          + shift
          + goto process_file_arg
          +)
          +if "%1" == "--file" (
          + set "FILE_ARG=%2"
          + shift
          + goto process_file_arg
          +)
          +@REM If none of the above, skip the argument
          +shift
          +if not "%~1" == "" (
          + goto arg_loop
          +) else (
          + goto findBaseDir
          +)
          +
          +:process_file_arg
          +if "%FILE_ARG%" == "" (
          + goto findBaseDir
          +)
          +call :get_directory_from_file %FILE_ARG%
          +if not exist "%POM_DIR%" (
          + echo Directory %POM_DIR% extracted from the f/-file command-line argument does not exist
          — End diff –

          OK

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on a diff in the pull request: https://github.com/apache/maven/pull/94#discussion_r86667117 — Diff: apache-maven/src/bin/mvn.cmd — @@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%* set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR% if not "%MAVEN_PROJECTBASEDIR%"=="" goto endDetectBaseDir -set "EXEC_DIR=%CD%" -set "WDIR=%EXEC_DIR%" +set EXEC_DIR=%CD% +set WDIR=%EXEC_DIR% + +@REM Look for the --file switch and start the search for the .mvn directory from the specified +@REM POM location, if supplied. + +set FILE_ARG= +:arg_loop +if "%1" == "-f" ( + set "FILE_ARG=%2" + shift + goto process_file_arg +) +if "%1" == "--file" ( + set "FILE_ARG=%2" + shift + goto process_file_arg +) +@REM If none of the above, skip the argument +shift +if not "%~1" == "" ( + goto arg_loop +) else ( + goto findBaseDir +) + +:process_file_arg +if "%FILE_ARG%" == "" ( + goto findBaseDir +) +call :get_directory_from_file %FILE_ARG% +if not exist "%POM_DIR%" ( + echo Directory %POM_DIR% extracted from the f/ -file command-line argument does not exist — End diff – OK
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          OK, addressed both comments from michael-o

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 OK, addressed both comments from michael-o
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/94

          @michael-o
          Any objections to merget this or do we need to test it with specific use case?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @michael-o Any objections to merget this or do we need to test it with specific use case?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          I think this really deserves an IT too. The shell script is fine. Can't just on the command script, I am virtually illiterate here. I trust @rpatrick00 here. Willing to blindly to merge when the IT is ready.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 I think this really deserves an IT too. The shell script is fine. Can't just on the command script, I am virtually illiterate here. I trust @rpatrick00 here. Willing to blindly to merge when the IT is ready.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven/pull/94

          @michael-o
          I will merge it no problem. The only problem on IT is my spare time.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @michael-o I will merge it no problem. The only problem on IT is my spare time.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          I would rather see @rpatrick00 providing the IT.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 I would rather see @rpatrick00 providing the IT.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          @michael-o, while I have no problem contributing, I have no familiarity with the maven-integration-test project so it will likely take me some time to reverse engineer it enough to figure out how to create an integration test for the shell scripts and the various use cases that should be tested. I would hate to see this fix gated by the requirement for me to accomplish this given the demands of my day job...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 @michael-o, while I have no problem contributing, I have no familiarity with the maven-integration-test project so it will likely take me some time to reverse engineer it enough to figure out how to create an integration test for the shell scripts and the various use cases that should be tested. I would hate to see this fix gated by the requirement for me to accomplish this given the demands of my day job...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          let's help: I dug into core-its, to find what existing IT to extend, since .mvn feature should have an IT already
          => found mng-5771-core-extensions IT, which already tests 3 conditions: I think it's the right place to add one more
          here are the pointers:

          I suppose writing the IT will simply require to copy testCoreExtension() method and not setting basedir on the Verifier, but add the new option

          here is core-its intro: http://maven.apache.org/core-its/core-it-suite/

          do you want to try? Or I do it (now that I had a look and found existing IT, seems easy)

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 let's help: I dug into core-its, to find what existing IT to extend, since .mvn feature should have an IT already => found mng-5771-core-extensions IT, which already tests 3 conditions: I think it's the right place to add one more here are the pointers: the IT source: https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5771CoreExtensionsTest.java associated test projects: https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5771-core-extensions/client I suppose writing the IT will simply require to copy testCoreExtension() method and not setting basedir on the Verifier, but add the new option here is core-its intro: http://maven.apache.org/core-its/core-it-suite/ do you want to try? Or I do it (now that I had a look and found existing IT, seems easy)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          @hboutemy Thanks for helping out!

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy Thanks for helping out!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          I know core ITs are intimidating: it took me years to really dig into the code!
          This case seems a simple one (what I didn't really expect when thinking at it initially), since it's only improving existing MNG-5771 IT with just different launch conditions

          if it is still too much intimidating, tell me: I'll do the IT showing the failure, and you'll add the fix

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 I know core ITs are intimidating: it took me years to really dig into the code! This case seems a simple one (what I didn't really expect when thinking at it initially), since it's only improving existing MNG-5771 IT with just different launch conditions if it is still too much intimidating, tell me: I'll do the IT showing the failure, and you'll add the fix
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          I took a quick look at the MNG-5771 IT and it's not obvious to me exactly what I need to do so if you can add this in a few minutes, that is probably the best thing to do. If not, I will try to look at it as I can and try some tests to figure out how it works...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 I took a quick look at the MNG-5771 IT and it's not obvious to me exactly what I need to do so if you can add this in a few minutes, that is probably the best thing to do. If not, I will try to look at it as I can and try some tests to figure out how it works...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jvanzyl commented on the issue:

          https://github.com/apache/maven/pull/94

          Please do not change an existing test. The conditions under which this IT passes should be left as-is and should continue running as it is in exactly the form it runs now. Making purely additional logic is fine, or copy that IT and make another test all together, do not change the logic or resources of the existing IT. It captures behavior that is currently deployed in released versions and so it should remain as a representation of that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jvanzyl commented on the issue: https://github.com/apache/maven/pull/94 Please do not change an existing test. The conditions under which this IT passes should be left as-is and should continue running as it is in exactly the form it runs now. Making purely additional logic is fine, or copy that IT and make another test all together, do not change the logic or resources of the existing IT. It captures behavior that is currently deployed in released versions and so it should remain as a representation of that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          IT added https://github.com/apache/maven-integration-testing/commit/2e74409fc2593b4478c40f28c7fdabc60202c06b
          no change on existing ITs, just added an additional run with different execution state: current dir = parent, mvn run with -f client/pom.xml
          of course, it is currently failing: I let Tibor or Michael apply the fix

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 IT added https://github.com/apache/maven-integration-testing/commit/2e74409fc2593b4478c40f28c7fdabc60202c06b no change on existing ITs, just added an additional run with different execution state: current dir = parent, mvn run with -f client/pom.xml of course, it is currently failing: I let Tibor or Michael apply the fix
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          IT moved to its own suite in https://github.com/apache/maven-integration-testing/commit/3311f4e345fe7e6c343fae737631b727aba5b910 to avoid running this IT with Maven 3.3.x, as it will fail

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 IT moved to its own suite in https://github.com/apache/maven-integration-testing/commit/3311f4e345fe7e6c343fae737631b727aba5b910 to avoid running this IT with Maven 3.3.x, as it will fail
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          @hboutemy I am bit confused by the IT. The issue was about having `.mvn` properly located to expand `maven.config`. I would expect some system property to be added and retrieved. Am I wrong?

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy I am bit confused by the IT. The issue was about having `.mvn` properly located to expand `maven.config`. I would expect some system property to be added and retrieved. Am I wrong?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          maybe I'm missing something...
          .mvn directory has to be found by shell script because of jvm.config particularly
          But once he directory is found by shell script, I suppose it is injected in JVM launch command to be used for every other file (maven.config and extensions.xml): that's perhaps where I'm wrong, I didn't check
          I just looked at Linux shell update, that properly finds jvm.config: and I supposed that the IT checking for extensions.xml was consistent.
          Perhaps this is just a beginning and has to be improved to check more that simply extensions.xml

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 maybe I'm missing something... .mvn directory has to be found by shell script because of jvm.config particularly But once he directory is found by shell script, I suppose it is injected in JVM launch command to be used for every other file ( maven.config and extensions.xml ): that's perhaps where I'm wrong, I didn't check I just looked at Linux shell update, that properly finds jvm.config : and I supposed that the IT checking for extensions.xml was consistent. Perhaps this is just a beginning and has to be improved to check more that simply extensions.xml
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          @rpatrick00 Can you shed some light here? What do you to properly picked up? `extensions.xml`, `maven.config`, and `jvm.config`, right?

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @rpatrick00 Can you shed some light here? What do you to properly picked up? `extensions.xml`, `maven.config`, and `jvm.config`, right?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          If you look at the shell script, it used to compute the "basedir" variable starting at the current working directory and then search upwards for the .mvn directory. Then, it set the MAVEN_PROJECTBASEDIR environment variable and added the contents of jvm.config. Finally, it passed it into the java command line using the -Dmaven.multiModuleProjectDirectory=$

          {MAVEN_PROJECTBASEDIR}

          argument.

          All my fix does it change the starting point to search for the .mvn directory if the f/-file argument is specified. The rest of the logic is exactly the same...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 If you look at the shell script, it used to compute the "basedir" variable starting at the current working directory and then search upwards for the .mvn directory. Then, it set the MAVEN_PROJECTBASEDIR environment variable and added the contents of jvm.config. Finally, it passed it into the java command line using the -Dmaven.multiModuleProjectDirectory=$ {MAVEN_PROJECTBASEDIR} argument. All my fix does it change the starting point to search for the .mvn directory if the f/ -file argument is specified. The rest of the logic is exactly the same...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          yes, that's exactly the part I was looking for. The shell script:

          1. finds the basedir
          2. uses it to load `jvm.config`
          3. then injects the value as `maven.multiModuleProjectDirectory` property for the java part to use it to load `maven.config` and `extensions.xml`

          then when the IT checks that `extensions.xml` is loaded, it shows one of the features: perhaps we could add checks for the 2 others, but I admint that when `extensions.xml` works, the other work too
          (in fact, I didn't find any IT for the 2 others, then adding a test could be useful to fix lack of previous IT...)

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 yes, that's exactly the part I was looking for. The shell script: 1. finds the basedir 2. uses it to load `jvm.config` 3. then injects the value as `maven.multiModuleProjectDirectory` property for the java part to use it to load `maven.config` and `extensions.xml` then when the IT checks that `extensions.xml` is loaded, it shows one of the features: perhaps we could add checks for the 2 others, but I admint that when `extensions.xml` works, the other work too (in fact, I didn't find any IT for the 2 others, then adding a test could be useful to fix lack of previous IT...)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          @hboutemy I would at least check for `jvm.config` because this is expanded in the script itself.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy I would at least check for `jvm.config` because this is expanded in the script itself.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          IMHO, the first thing is to check in the current fix, since ITs are currently broken
          then improving the IT to check more parts could be interesting: priority 2

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 IMHO, the first thing is to check in the current fix, since ITs are currently broken then improving the IT to check more parts could be interesting: priority 2
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          I just merged the patch
          I had to change `==` tests to `=` since it did not work on Linux: the result is `if [ "$arg" = "f" -o "$arg" = "-file" ]; then`
          And it required a little update to the IT to force JVM fork, to force use of the shell script when launching IT build
          Everything seems good: I hope ASF Jenkins will tell that it works like it worked on my machine

          Thank you @rpatrick00 and Maven devs who helped him: this one is a great improvement

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 I just merged the patch I had to change `==` tests to `=` since it did not work on Linux: the result is `if [ "$arg" = " f" -o "$arg" = " -file" ]; then` And it required a little update to the IT to force JVM fork, to force use of the shell script when launching IT build Everything seems good: I hope ASF Jenkins will tell that it works like it worked on my machine Thank you @rpatrick00 and Maven devs who helped him: this one is a great improvement
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #18 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/18/)
          MNG-5889 - adding logic that looks for the file argument and starts the (hboutemy: rev da5b4df930925a0cbee95cfdca5c249ff143d91b)

          • (edit) apache-maven/src/bin/mvn
          • (edit) apache-maven/src/bin/mvn.cmd
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #18 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/18/ ) MNG-5889 - adding logic that looks for the file argument and starts the (hboutemy: rev da5b4df930925a0cbee95cfdca5c249ff143d91b) (edit) apache-maven/src/bin/mvn (edit) apache-maven/src/bin/mvn.cmd
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1419 (See https://builds.apache.org/job/maven-3.x/1419/)
          MNG-5889 - adding logic that looks for the file argument and starts the (hboutemy: rev da5b4df930925a0cbee95cfdca5c249ff143d91b)

          • (edit) apache-maven/src/bin/mvn.cmd
          • (edit) apache-maven/src/bin/mvn
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1419 (See https://builds.apache.org/job/maven-3.x/1419/ ) MNG-5889 - adding logic that looks for the file argument and starts the (hboutemy: rev da5b4df930925a0cbee95cfdca5c249ff143d91b) (edit) apache-maven/src/bin/mvn.cmd (edit) apache-maven/src/bin/mvn
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 commented on the issue:

          https://github.com/apache/maven/pull/94

          @hboutemy, sorry but both "==" and "=" seem to work fine on Oracle Linux and MacOS (where I tested the sh script). Not sure which version of Linux caused this but thanks for fixing it...

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy, sorry but both "==" and "=" seem to work fine on Oracle Linux and MacOS (where I tested the sh script). Not sure which version of Linux caused this but thanks for fixing it...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          FYI I'm running Kubuntu 16.10
          not a big issue: thank your for the great job
          please take time to close the PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 FYI I'm running Kubuntu 16.10 not a big issue: thank your for the great job please take time to close the PR
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rpatrick00 closed the pull request at:

          https://github.com/apache/maven/pull/94

          Show
          githubbot ASF GitHub Bot added a comment - Github user rpatrick00 closed the pull request at: https://github.com/apache/maven/pull/94
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user neykov opened a pull request:

          https://github.com/apache/brooklyn-server/pull/436

          Set default JVM memory settings for the build

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/neykov/brooklyn-server maven-opts

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/brooklyn-server/pull/436.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #436


          commit 3fae36300e4b606ee1c9a60982c1d1d4687cce48
          Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
          Date: 2016-11-15T07:17:07Z

          Set default JVM memory settings for the build


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-server/pull/436 Set default JVM memory settings for the build Will be picked up when building a sub-module Doesn't work with `--file` option ( MNG-5889 ( https://issues.apache.org/jira/browse/MNG-5889 )) You can merge this pull request into a Git repository by running: $ git pull https://github.com/neykov/brooklyn-server maven-opts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-server/pull/436.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #436 commit 3fae36300e4b606ee1c9a60982c1d1d4687cce48 Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com> Date: 2016-11-15T07:17:07Z Set default JVM memory settings for the build
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user neykov opened a pull request:

          https://github.com/apache/brooklyn-ui/pull/38

          Set default JVM memory settings for the build

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/neykov/brooklyn-ui maven-opts

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/brooklyn-ui/pull/38.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #38


          commit 196afbdef108bd3d500b01dafc8f556774f7da2d
          Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
          Date: 2016-11-15T07:19:31Z

          Set default JVM memory settings for the build


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-ui/pull/38 Set default JVM memory settings for the build Will be picked up when building a sub-module Doesn't work with `--file` option ( MNG-5889 ( https://issues.apache.org/jira/browse/MNG-5889 )) You can merge this pull request into a Git repository by running: $ git pull https://github.com/neykov/brooklyn-ui maven-opts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-ui/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 196afbdef108bd3d500b01dafc8f556774f7da2d Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com> Date: 2016-11-15T07:19:31Z Set default JVM memory settings for the build
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user neykov opened a pull request:

          https://github.com/apache/brooklyn-client/pull/33

          Set default JVM memory settings for the build

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/neykov/brooklyn-client maven-opts

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/brooklyn-client/pull/33.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #33


          commit 8cf2f37dc8a8582d50c2f3bac98e7512a2be6716
          Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
          Date: 2016-11-15T07:18:10Z

          Set default JVM memory settings for the build


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-client/pull/33 Set default JVM memory settings for the build Will be picked up when building a sub-module Doesn't work with `--file` option ( MNG-5889 ( https://issues.apache.org/jira/browse/MNG-5889 )) You can merge this pull request into a Git repository by running: $ git pull https://github.com/neykov/brooklyn-client maven-opts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-client/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 8cf2f37dc8a8582d50c2f3bac98e7512a2be6716 Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com> Date: 2016-11-15T07:18:10Z Set default JVM memory settings for the build
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user neykov opened a pull request:

          https://github.com/apache/brooklyn-dist/pull/59

          Set default JVM memory settings for the build

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/neykov/brooklyn-dist maven-opts

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/brooklyn-dist/pull/59.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #59


          commit e73b82b0f62a297735f7b4ef519787b883bdf821
          Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
          Date: 2016-11-15T07:18:27Z

          Set default JVM memory settings for the build


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-dist/pull/59 Set default JVM memory settings for the build Will be picked up when building a sub-module Doesn't work with `--file` option ( MNG-5889 ( https://issues.apache.org/jira/browse/MNG-5889 )) You can merge this pull request into a Git repository by running: $ git pull https://github.com/neykov/brooklyn-dist maven-opts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-dist/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit e73b82b0f62a297735f7b4ef519787b883bdf821 Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com> Date: 2016-11-15T07:18:27Z Set default JVM memory settings for the build
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/94

          @hboutemy Are you waiting for the Jenkins build to close the JIRA issue? @rpatrick00 Thank you for the contribution.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/94 @hboutemy Are you waiting for the Jenkins build to close the JIRA issue? @rpatrick00 Thank you for the contribution.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/94

          yes: now that ASF Jenkins shows me it works not only on my Linux box but also on ASF Linux and on Windows, I just closed the Jira issue

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/94 yes: now that ASF Jenkins shows me it works not only on my Linux box but also on ASF Linux and on Windows, I just closed the Jira issue
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/brooklyn-server/pull/436

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/436
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #20 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/20/)
          MNG-5889 .mvn directory should be picked when using --file (gboue: rev 8ae1a3e92418fbac59acb07fcbd668d3735c1945)

          • (edit) apache-maven/src/bin/mvn.cmd
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #20 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/20/ ) MNG-5889 .mvn directory should be picked when using --file (gboue: rev 8ae1a3e92418fbac59acb07fcbd668d3735c1945) (edit) apache-maven/src/bin/mvn.cmd
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1421 (See https://builds.apache.org/job/maven-3.x/1421/)
          MNG-5889 .mvn directory should be picked when using --file (gboue: rev 8ae1a3e92418fbac59acb07fcbd668d3735c1945)

          • (edit) apache-maven/src/bin/mvn.cmd
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1421 (See https://builds.apache.org/job/maven-3.x/1421/ ) MNG-5889 .mvn directory should be picked when using --file (gboue: rev 8ae1a3e92418fbac59acb07fcbd668d3735c1945) (edit) apache-maven/src/bin/mvn.cmd
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/brooklyn-library/pull/74

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/74
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/brooklyn-ui/pull/38

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/38
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/brooklyn-client/pull/33

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-client/pull/33
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/brooklyn-dist/pull/59

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/59
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1477 (See https://builds.apache.org/job/maven-3.x/1477/)
          MNG-5889 .mvn directory should be picked when using --file (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=1a94cd4a76cd528eb4b8f46b853f8d77d7d5352d)

          • (edit) apache-maven/src/bin/mvn.cmd
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1477 (See https://builds.apache.org/job/maven-3.x/1477/ ) MNG-5889 .mvn directory should be picked when using --file (schulte: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=1a94cd4a76cd528eb4b8f46b853f8d77d7d5352d ) (edit) apache-maven/src/bin/mvn.cmd
          Hide
          stephenc Stephen Connolly added a comment -

          Maven 3.4.0 has been dropped. See this thread for more details.

          This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.

          Show
          stephenc Stephen Connolly added a comment - Maven 3.4.0 has been dropped. See this thread for more details. This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/brooklyn/pull/8

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/brooklyn/pull/8
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1547 (See https://builds.apache.org/job/maven-3.x/1547/)
          MNG-5889 .mvn directory should be picked when using --file (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca)

          • (edit) apache-maven/src/bin/mvn
          • (edit) apache-maven/src/bin/mvn.cmd
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1547 (See https://builds.apache.org/job/maven-3.x/1547/ ) MNG-5889 .mvn directory should be picked when using --file (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca ) (edit) apache-maven/src/bin/mvn (edit) apache-maven/src/bin/mvn.cmd

            People

            • Assignee:
              tibor17 Tibor Digana
              Reporter:
              daniel.spilker@hamburg.de Daniel Spilker
            • Votes:
              3 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development