[MNG-5871] make url inheritance algorithm more visible

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.3
• Fix Version/s: 3.3.9
• Component/s: Inheritance and Interpolation
• Assignee: Herve Boutemy
• Reporter: Herve Boutemy
• Created: 13/Aug/15 00:23
• Updated: 28/Mar/20 14:59
• Resolved: 17/Aug/15 19:08

Description

currently, default urls calculated for child from parent values are often discussed
but their implementation is no easy to find: it's a mix between

• DefaultInheritanceAssembler.getChildPathAdjustment(, which calculates path adjustment
• MavenModelBuilder.appendPath, that calculates the child url: in general, parent url is used, but if childpathadjustment is set, this is the algorithm to extrapolate child from parent

IMHO, the test on childpathadjustement is a hack; in fact, we should use method overriding: default method just returns arent, but DefaultInheritanceAssembler.InheritanceModelMerger should override it with the extrapolation algorithm

this would make the code a lot more clear and help for future enhancements

Issue Links

• is depended upon by: MNG-5951 add an option to avoid path addition to inherited URLs
• is related to: MNG-5878 add support for module name != artifactId in every calculated URLs (project, SCM, site): special project.directory property