[MNG-5794] Warn about Proxies with duplicate id, but different protocols

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.3
• Component/s: Settings
• Assignee: Robert Scholte
• Reporter: Thomas Meyer
• Created: 28/Mar/15 05:42
• Updated: 28/Mar/20 14:59
• Resolved: 06/Apr/15 16:17

Description

I did copy the HTTPS proxy entry and modified it into a HTTP entry in
the settings.xml.
But I forgot to change the id of the second proxy entry.
It took me a while to figure out why it isn't working...

Untested patch, but I hope you get the idea!

with kind regards
thomas

diff --git a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
--- a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
+++ b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
@@ -162,7 +162,10 @@
     private boolean useLegacyLocalRepositoryManager = false;
 
     private Map<String, Object> data;
-    
+
+    @Inject
+    private Logger logger;
+
     public DefaultMavenExecutionRequest()
     {
     }
@@ -788,7 +791,14 @@ public MavenExecutionRequest addProxy( Proxy proxy )
         {
             if ( p.getId() != null && p.getId().equals( proxy.getId() ) )
             {
-                return this;
+                if( !( p.getProtocol().equals( proxy.getProtocol() ) ) )
+                {
+                    logger.warn( "Duplicate proxy id found! But protocol differs!\n" +
+                                 "Please check your settings.xml file!" );
+                } else
+                {
+                    return this;
+                }
             }
         }