[MNG-5579] Unify error output/check logic from shell and batch scripts

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.5.0-alpha-1, 3.5.0
• Component/s: Command Line
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 08/Feb/14 10:06
• Updated: 23/Feb/17 15:02
• Resolved: 30/Jan/17 21:33

Description

Currently,

both output two different messages.

Shell:

Error: JAVA_HOME is not defined correctly.
We cannot execute $JAVACMD

while batch says:

Error: JAVA_HOME not found in your environment.
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.

Same applies for M2_HOME. Additionally, testing for the Java command is handled different in both scripts. The batch script relies on JAVA_HOME while the shell script can ignore it. Both should require JAVA_HOME or warn about and use which java, respectively java in PATH (for %%X in (java.exe) do (set JAVACMD=%%~$PATH:X)) on Windows. After that should proceed to checking M2_HOME.

Any thoughts?

Issue Links

• depends upon: MNG-5607 Don't use M2_HOME in mvn shell/command scripts anymore
• depends upon: MNG-6003 Drastically reduce JAVA_HOME discovery code
• relates to: MNG-5574 Write error/warning messages from mvn shell and batch scripts to stderr
• mentioned in: Page Loading...