[MNG-4657] SettingsUtils.copySettings does not perform a deep copy

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.1
• Fix Version/s: 3.0-alpha-3
• Component/s: Settings
• Assignee: Benjamin Bentmann
• Reporter: Edouard Hue
• Created: 03/May/10 14:48
• Updated: 03/May/10 14:59
• Resolved: 03/May/10 14:59

Description

The org.apache.maven.settings.SettingsUtils.copySettings method only creates a new Settings instance and then copies all its attributes by reference, including lists such as profiles or proxies. Hence, modifying the copy can produce unexpected side effects on the original object.

Expected behavior is that a deep copy is returned, or documentation should mention this behaviour. Maybe make it implement Clonable ?