[MNG-3734] npe when settings missing <mirrorOf> tag

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.0.9
• Component/s: Settings
• Assignee: Brett Porter
• Reporter: Eugene Kuleshov
• Created: 28/Aug/08 19:36
• Updated: 18/Dec/08 09:13
• Resolved: 18/Dec/08 09:13

Description

When mirrors section in settings.xml is missing <mirrorOf>:

<mirror>
<id>ATOS-XA</id>
<url>http://xa.atosworldline.com/repository/maven/</url>
</mirror>

It cause an NPE:

java.lang.NullPointerException
	at org.apache.maven.artifact.manager.DefaultWagonManager.matchPattern(DefaultWagonManager.java:857)
	at org.apache.maven.artifact.manager.DefaultWagonManager.getMirror(DefaultWagonManager.java:829)
	at org.apache.maven.artifact.manager.DefaultWagonManager.getMirrorRepository(DefaultWagonManager.java:668)
	at org.apache.maven.artifact.manager.DefaultWagonManager.getArtifact(DefaultWagonManager.java:418)
	at org.apache.maven.artifact.manager.DefaultWagonManager.getArtifact(DefaultWagonManager.java:335)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:193)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:83)
	at org.maven.ide.eclipse.internal.project.EclipseArtifactResolver.resolve(EclipseArtifactResolver.java:34)
	at org.apache.maven.project.DefaultMavenProjectBuilder.findModelFromRepository(DefaultMavenProjectBuilder.java:552)
	at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:233)
	at org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:131)
	at org.apache.maven.artifact.resolver.DefaultArtifactCollector.recurse(DefaultArtifactCollector.java:518)
	at org.apache.maven.artifact.resolver.DefaultArtifactCollector.collect(DefaultArtifactCollector.java:138)
	at org.apache.maven.artifact.resolver.DefaultArtifactCollector.collect(DefaultArtifactCollector.java:88)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:526)
	at org.apache.maven.project.DefaultMavenProjectBuilder.buildProjectWithDependencies(DefaultMavenProjectBuilder.java:404)
	at org.apache.maven.embedder.MavenEmbedder.readProjectWithDependencies_aroundBody0(MavenEmbedder.java:453)
	at org.apache.maven.embedder.MavenEmbedder.readProjectWithDependencies_aroundBody1$advice(MavenEmbedder.java:304)
	at org.apache.maven.embedder.MavenEmbedder.readProjectWithDependencies(MavenEmbedder.java:1)
	at org.maven.ide.eclipse.internal.project.MavenProjectManagerImpl$MavenProjectReader.execute(MavenProjectManagerImpl.java:1053)
	at org.maven.ide.eclipse.internal.project.MavenProjectManagerImpl.execute(MavenProjectManagerImpl.java:995)
	at org.maven.ide.eclipse.internal.project.MavenProjectManagerImpl.refresh(MavenProjectManagerImpl.java:377)
	at org.maven.ide.eclipse.internal.project.MavenProjectManagerImpl.refresh(MavenProjectManagerImpl.java:351)
	at org.maven.ide.eclipse.internal.project.MavenProjectManagerRefreshJob.run(MavenProjectManagerRefreshJob.java:85)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Adding <mirrorOf> fixes issue. See MNGECLIPSE-872 for more details

It would really help if build failed with more meaningful error.

Issue Links

• duplicates: MNG-3616 Null Pointer Exception when mirrorOf missing from mirror in settings.xml