Maven
  1. Maven
  2. MNG-3475

Some directories are not basedir aligned

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.8
    • Fix Version/s: 2.1.0-M1
    • Component/s: POM
    • Labels:
      None
    • Flags:
      Patch

      Description

      The output from

      <echo>${project.build.sourceDirectory}</echo>
      <echo>${project.build.testSourceDirectory}</echo>
      <echo>${project.build.scriptSourceDirectory}</echo>
      <echo>${project.build.directory}</echo>
      <echo>${project.build.outputDirectory}</echo>
      <echo>${project.build.testOutputDirectory}</echo>
      <echo>${project.reporting.outputDirectory}</echo>
      

      delivers something like

      [echo] M:\maven\z\antrun\src\main\java
      [echo] M:\maven\z\antrun\src\test\java
      [echo] src/main/scripts
      [echo] M:\maven\z\antrun\target
      [echo] M:\maven\z\antrun\target\classes
      [echo] M:\maven\z\antrun\target\test-classes
      [echo] target/site
      

      revealing that neither the script source directory nor the reporting output directory are basedir aligned.

      1. base-directory-alignment.patch
        6 kB
        Benjamin Bentmann
      2. base-directory-alignment.patch
        21 kB
        Benjamin Bentmann

        Issue Links

          Activity

          Benjamin Bentmann created issue -
          Hide
          Benjamin Bentmann added a comment -

          Overlooked unalignment.

          Show
          Benjamin Bentmann added a comment - Overlooked unalignment.
          Benjamin Bentmann made changes -
          Field Original Value New Value
          Attachment base-directory-alignment.patch [ 33380 ]
          Benjamin Bentmann made changes -
          Attachment base-directory-alignment.patch [ 33366 ]
          Hide
          Benjamin Bentmann added a comment -

          Not even that DefaultPathTranslator misses some directories, it crashes on certain inputs, too. E.g. {{alignToBaseDirectory( "$

          {basedir}

          ", basedir )}} bails out with a StringIndexOutOfBoundsException.

          I took this opportunity to clean this component up, adding javadocs and unit tests.

          Show
          Benjamin Bentmann added a comment - Not even that DefaultPathTranslator misses some directories, it crashes on certain inputs, too. E.g. {{alignToBaseDirectory( "$ {basedir} ", basedir )}} bails out with a StringIndexOutOfBoundsException . I took this opportunity to clean this component up, adding javadocs and unit tests.
          Benjamin Bentmann made changes -
          Attachment base-directory-alignment.patch [ 33392 ]
          Benjamin Bentmann made changes -
          Link This issue relates to MNG-3498 [ MNG-3498 ]
          Benjamin Bentmann made changes -
          Fix Version/s 2.0.10 [ 14112 ]
          Hide
          Shane Isbell added a comment -

          Bug fix here: https://svn.apache.org/repos/asf/maven/sandbox/branches/MNG-3536

          This is part of a rewrite of the interpolation code.

          Show
          Shane Isbell added a comment - Bug fix here: https://svn.apache.org/repos/asf/maven/sandbox/branches/MNG-3536 This is part of a rewrite of the interpolation code.
          Hide
          Benjamin Bentmann added a comment - - edited

          Bug fix here: https://svn.apache.org/repos/asf/maven/sandbox/branches/MNG-3536

          No, it isn't. This issue is about missing path translation, not interpolation.

          Show
          Benjamin Bentmann added a comment - - edited Bug fix here: https://svn.apache.org/repos/asf/maven/sandbox/branches/MNG-3536 No, it isn't. This issue is about missing path translation, not interpolation.
          John Casey made changes -
          Assignee John Casey [ jdcasey ]
          John Casey made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          John Casey added a comment -

          scriptSourceRoots won't work unless they're passed on to the maven-plugin-tools-api scanner instance as relative paths. This is as of 2.4.3 (actually I'm fixing that in 2.4.4-SNAPSHOT, so earlier snapshots won't accommodate absolute paths either).

          I'll open another issue for this.

          Show
          John Casey added a comment - scriptSourceRoots won't work unless they're passed on to the maven-plugin-tools-api scanner instance as relative paths. This is as of 2.4.3 (actually I'm fixing that in 2.4.4-SNAPSHOT, so earlier snapshots won't accommodate absolute paths either). I'll open another issue for this.
          John Casey made changes -
          Fix Version/s 2.1.0-M1 [ 14503 ]
          Fix Version/s 2.0.10 [ 14112 ]
          Benjamin Bentmann made changes -
          Link This issue is related to MNG-3741 [ MNG-3741 ]
          Benjamin Bentmann made changes -
          Link This issue is depended upon by MNG-3822 [ MNG-3822 ]
          Benjamin Bentmann made changes -
          Link This issue is related to MNG-1927 [ MNG-1927 ]
          Benjamin Bentmann made changes -
          Link This issue relates to MNG-3877 [ MNG-3877 ]
          Benjamin Bentmann made changes -
          Link This issue relates to MNG-4061 [ MNG-4061 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 08:49:45 UTC 2015 [ 1428223785911 ]
          Mark Thomas made changes -
          Workflow jira [ 12713895 ] Default workflow, editable Closed status [ 12753634 ]
          Mark Thomas made changes -
          Flags Patch [ 10430 ]
          Patch Submitted Yes [ 10763 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 21:45:26 UTC 2015 [ 1428270326204 ]
          Mark Thomas made changes -
          Workflow jira [ 12952236 ] Default workflow, editable Closed status [ 12989586 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          96d 2h 39m 1 John Casey 25/Jun/08 16:55

            People

            • Assignee:
              John Casey
              Reporter:
              Benjamin Bentmann
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development