[MNG-3454] processing a relocation erases requested version range

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Incomplete
• Affects Version/s: 2.0.5, 2.0.6, 2.0.7, 2.0.8
• Component/s: Artifacts and Repositories
• Assignee: Unassigned
• Reporter: Brian E Fox
• Created: 10/Mar/08 20:27
• Updated: 30/Jun/23 11:42
• Resolved: 22/Jan/14 20:32

Description

While fixing MNG-2861, I came across a weird scenario where the contents of the relocation can affect what happens. In 2861, the relocation did not specify a version, only a group id. However, if a version is specified, in MavenMetadataSource: 164 the versionRange is reset to the contents of the relocation.getVersion(). This effectively tosses out the requested range information. We only get here after selecting the version that has been relocated, but now we have a recommended version, which can cause a different version to be selected. See the two sample projects in MNG-2861 to see how the handling is different. (brett's version has the version in the relocation and thus expresses the behavior described here)

The fix is simple, change the line to:
if ( relocation.getVersion() != null )

{ //we don't want to blast the versionRange information artifact.selectVersion( relocation.getVersion() ); }

however, I'm not certain what the ramifications of this are. The potential exists for having selected a version that no longer matches the requested version range. Say the version range was [1.0,2.0] and 2.0 was relocated to 3.0. The fix to 2861 involves reloading the available versions from the relocated artifact. This means that there is no not an artifact to match 1.0-2.0 and who knows what's going to happen.

I'm choosing to document this and not fix it for now due to the risk of instability. A search of open issues didn't result in anyone experiencing trouble with this.

Issue Links

• relates to: MRESOLVER-379 Problem when relocations and ranges are used in collection
• relates to: MNG-2861 NullPointerException in DefaultArtifactCollector for relocated resolvedArtifacts with different version ranges and available versions.