[MNG-3443] boolean values in the POM specified as expressions are not interpolated, result in value == false

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.0.8, 2.0.9, 3.0-alpha-1
• Component/s: POM
• Assignee: Brett Porter
• Reporter: John Dennis Casey
• Created: 06/Mar/08 12:45
• Updated: 18/Dec/08 08:34
• Resolved: 18/Dec/08 08:34

Description

The problem is the ModelReader generated by Modello uses something akin to Boolean.valueOf( element.getValue() ) to set boolean model values. If the value in XML is actually an expression, it is resolved to false and never interpolated.

To correct this, we should consider revising Modelllo's generated reader architecture to use a two-stage approach:

1. Construct a raw structure of String: String and String: Collection associations (basically something like a perlish hash, IIRC)
2. Pass an arbitrary number of transformers over the raw structure to interpolate it (this includes path translation, etc. and should include a notion of transformation context to allow transformations to collaborate)
3. Construct the Model instance based on the transformed raw structure.

This will incur a little extra transient overhead for model construction, but its effects should be mitigated through the caching strategies we employ for models and projects.

Issue Links

• duplicates: MNG-1995 filtering element in pom.xml ignore properties