Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-3266

maven-model RepositoryBase overrides equals() but not hashCode()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.7
    • 2.2.2, 3.0-alpha-6
    • None
    • None

    Description

      Overriding equals and not hashCode is considered bad practice. Also, while looking around, I noticed the two subclasses (Repository and PluginRepository) both override equals and just call "super.equals()". There is a cryptic comment nearby that leads me to believe this is a temporary fix for an old problem.

      Attachments

        1. MNG-3266-maven-model.patch
          2 kB
          jroberts
        2. MNG-3266-maven-model-v2.patch
          3 kB
          jroberts

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. MNG-2817 Add identity specification in maven-model and maven-settings

          • Major - Major loss of function.
          • Closed

          Activity

            People

              hboutemy Herve Boutemy
              jroberts jroberts
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: