[MNG-3046] DefaultArtifactVersion compareTo misbehaves regarding buildNumber 0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.6
• Fix Version/s: 2.0.8, 3.0-alpha-1
• Component/s: Artifacts and Repositories
• Flags: Patch
• Assignee: John Dennis Casey
• Reporter: David Julian
• Created: 11/Jun/07 13:44
• Updated: 05/Apr/15 14:54
• Resolved: 14/Aug/07 10:22

Description

The implementation of Comparable.compareTo(Object) is faulty regarding the handling of version numbers where a build number is present but zero. Here's a unit test to demonstrate:

DefaultArtifactVersion v1 = new DefaultArtifactVersion("2.0");
DefaultArtifactVersion v2 = new DefaultArtifactVersion("2.0-0");
DefaultArtifactVersion v3 = new DefaultArtifactVersion("2.0-alpha1");

// v1 and v2 are equal
assertTrue( v1.compareTo(v2) == 0 );
assertTrue( v2.compareTo(v1) == 0 );

// v1 is newer than v3
assertTrue( v1.compareTo(v3) > 0 );
assertTrue( v3.compareTo(v1) < 0 );

// ergo, v2 should also be newer than v3
assertTrue( v2.compareTo(v3) > 0 ); // FAILS!! returns 0 (equal)
assertTrue( v3.compareTo(v1) < 0 ); // succeeds

This test demonstrates this behavior violates symmetry and transitivity.

Luckily, the fix is easy. A small change to the compareTo method to consider qualifiers before build numbers relieves this issue. I have a patch that I'll submit as soon as I have the issue number.

Issue Links

• relates to: MNG-3047 DefaultArtifactVersion compareTo inconsistent with equals