Maven
  1. Maven
  2. MNG-2985

DefaultWagonManager does not safely remove TransferListeners from the wagon

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0-alpha-1
    • Fix Version/s: 3.0-alpha-1
    • Component/s: None
    • Labels:
      None
    • Environment:
      osx intel, java 5

      Description

      The method "getRemoteFile()" registers several transfer listeners, but never removes them.
      The method "putRemoteFile()" might left transfer listeners registered if an exception is raised.

      The results is that executing those method repeteadly continously increments the number of listeners. When embedded, the problem is specially relevant (see http://jira.codehaus.org/browse/MNGECLIPSE-302).

      Attached is a patch with test cases.

      1. MNG-2985-maven-artifact.patch
        10 kB
        Abel Muiño
      2. MNG-2985-maven-artifact.patch
        8 kB
        Abel Muiño
      3. MNG-2985-maven-artifact.with-license.patch
        11 kB
        Abel Muiño

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        2d 3h 41m 1 Carlos Sanchez 14/May/07 22:16
        Mark Thomas made changes -
        Workflow jira [ 12950315 ] Default workflow, editable Closed status [ 12986535 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:45:26 UTC 2015 [ 1428270326204 ]
        Mark Thomas made changes -
        Workflow jira [ 12713496 ] Default workflow, editable Closed status [ 12753242 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:49:45 UTC 2015 [ 1428223785911 ]
        Carlos Sanchez made changes -
        Assignee Carlos Sanchez [ carlos ]
        Resolution Fixed [ 1 ]
        Fix Version/s 2.1-alpha-1 [ 13143 ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        Carlos Sanchez added a comment -

        Applied with some refactorings

        Show
        Carlos Sanchez added a comment - Applied with some refactorings
        Abel Muiño made changes -
        Attachment MNG-2985-maven-artifact.with-license.patch [ 27330 ]
        Hide
        Abel Muiño added a comment -

        License added.

        Show
        Abel Muiño added a comment - License added.
        Hide
        Carlos Sanchez added a comment -

        just for legal reasons can you add the licnese header to WagonNoop as the other files have?

        Show
        Carlos Sanchez added a comment - just for legal reasons can you add the licnese header to WagonNoop as the other files have?
        Abel Muiño made changes -
        Attachment MNG-2985-maven-artifact.patch [ 27308 ]
        Hide
        Abel Muiño added a comment -

        Included WagonNoOp in the patch.

        Show
        Abel Muiño added a comment - Included WagonNoOp in the patch.
        Hide
        Carlos Sanchez added a comment -

        you are missing Wagonnoop class in the patch

        Show
        Carlos Sanchez added a comment - you are missing Wagonnoop class in the patch
        Abel Muiño made changes -
        Link This issue is depended upon by MNGECLIPSE-302 [ MNGECLIPSE-302 ]
        Abel Muiño made changes -
        Field Original Value New Value
        Attachment MNG-2985-maven-artifact.patch [ 27284 ]
        Hide
        Abel Muiño added a comment -

        Patch for the issue, with test cases.

        Show
        Abel Muiño added a comment - Patch for the issue, with test cases.
        Abel Muiño created issue -

          People

          • Assignee:
            Carlos Sanchez
            Reporter:
            Abel Muiño
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development