[MNG-2925] NullPointerException in PluginDescriptor.getMojo() if there's no mojo in pom.xml

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.9, 3.0-alpha-1
• Component/s: Plugin API
• Assignee: Siveton Vincent
• Reporter: Kohsuke Kawaguchi
• Created: 03/Apr/07 15:20
• Updated: 07/Jan/08 05:48
• Resolved: 07/Jan/08 05:48

Description

The getMojo method fails with NPE because getMojos() method returns null. This happens when there's no mojo in the plugin.
The code should be modified to check for this situation, like this:

public MojoDescriptor getMojo( String goal )
{
List mojos = getMojos();
if(mojos==null) return null; // no mojo in this POM

MojoDescriptor mojoDescriptor = null;
for ( Iterator i = mojos.iterator(); i.hasNext() && mojoDescriptor == null; )
{
MojoDescriptor desc = (MojoDescriptor) i.next();
if ( goal.equals( desc.getGoal() ) )

{ mojoDescriptor = desc; }

}
return mojoDescriptor;
}

{/code}