[MNG-2635] DefaultArtifactCollector.recurse can lose versionRange

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.7
• Component/s: Artifacts and Repositories
• Environment: Linux
• Flags: Patch
• Assignee: Brian E Fox
• Reporter: Bud Osterberg
• Created: 26/Oct/06 19:32
• Updated: 10/Mar/16 13:50
• Resolved: 12/Mar/08 14:02

Description

This affects maven 2.0.4 and 2.0.5 (at least).

I'm not quite sure how to reproduce the bug in a simple test case, but we have a setup where running the command:
mvn install site source:jar
crashes in ArtifactUtils.copyArtifact because artifact.getVersionRange() returns null.
The code that seems to be causing the problem is in DefaultArtifactCollector.recurse(). Because the Artifact sets the version in setVersionRange, but can't set the VersionRange from setVersion, the VersionRange should take precedence if it exists. A simple diff follows:

Index: components/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
===================================================================
— components/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java (revision 467177)
+++ components/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java (working copy)
@@ -114,8 +114,13 @@

fireEvent( ResolutionListener.MANAGE_ARTIFACT, listeners, node, artifact );

• if ( artifact.getVersion() != null )
  + VersionRange range = artifact.getVersionRange();
  + if (range != null) { + node.getArtifact().setVersionRange(range); + }

  + else if ( artifact.getVersion() != null )
  +

  { node.getArtifact().setVersion( artifact.getVersion() ); }

  if ( artifact.getScope() != null )

Issue Links

• is related to: MNG-2928 Null pointer exeception when introducing version range [major.minor.build-SNAPSHOT,)