[MJAVADOC-342] An incomplete fix for the NPE bugs in AbstractJavadocMojo.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9
• Assignee: Benson Margulies
• Reporter: Guangtai Liang
• Created: 15/Feb/12 21:53
• Updated: 16/Sep/12 09:58
• Resolved: 15/Sep/12 18:23

Description

The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.

The buggy code locations the same fix needs to be applied at are as bellows:

Line 2401 of the method "copyJavadocResources";
Line 1505 of the method "getSourcePaths".