Maven Invoker Plugin
  1. Maven Invoker Plugin
  2. MINVOKER-30

Allow to configure file encoding for verifications scripts

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Labels:
      None
    • Flags:
      Patch

      Description

      Right now, the verify.bsh is read using the platform's default encoding, making the tests platform-dependent. We should enrich the plugin configuration to allow the user to lock down the encoding and ensure reproducible tests.

      The same applies to the goals.txt and profiles.txt.

      1. file-encoding.patch
        2 kB
        Benjamin Bentmann

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          15d 13h 19m 1 Benjamin Bentmann 18/Apr/08 08:00
          Closed Closed Reopened Reopened
          13d 20h 29m 1 Benjamin Bentmann 02/May/08 04:30
          Reopened Reopened Closed Closed
          1d 16m 1 Benjamin Bentmann 03/May/08 04:46
          Mark Thomas made changes -
          Workflow jira [ 12959258 ] Default workflow, editable Closed status [ 12996193 ]
          Mark Thomas made changes -
          Project Import Mon Apr 06 00:02:09 UTC 2015 [ 1428278529346 ]
          Mark Thomas made changes -
          Patch Submitted Yes [ 10763 ]
          Flags Patch [ 10430 ]
          Mark Thomas made changes -
          Workflow jira [ 12721742 ] Default workflow, editable Closed status [ 12762115 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 10:28:53 UTC 2015 [ 1428229733495 ]
          Hervé Boutemy made changes -
          Link This issue is related to MNG-2216 [ MNG-2216 ]
          Benjamin Bentmann made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Closed [ 6 ]
          Hide
          Benjamin Bentmann added a comment -

          Done in r653017.

          Show
          Benjamin Bentmann added a comment - Done in r653017 .
          Benjamin Bentmann made changes -
          Link This issue is depended upon by MINVOKER-34 [ MINVOKER-34 ]
          Benjamin Bentmann made changes -
          Status Closed [ 6 ] Reopened [ 4 ]
          Resolution Fixed [ 1 ]
          Hide
          Benjamin Bentmann added a comment -

          Defaults needs to be changed to platform encoding.

          Show
          Benjamin Bentmann added a comment - Defaults needs to be changed to platform encoding.
          Benjamin Bentmann made changes -
          Resolution Fixed [ 1 ]
          Assignee Benjamin Bentmann [ bentmann ]
          Status Open [ 1 ] Closed [ 6 ]
          Fix Version/s 1.2 [ 13948 ]
          Hide
          Benjamin Bentmann added a comment -

          Committed in r649475.

          Show
          Benjamin Bentmann added a comment - Committed in r649475 .
          Benjamin Bentmann made changes -
          Field Original Value New Value
          Description Right now, the {{verify.bsh}} is read using the platform's default encoding, making the tests platform-dependent. We should enrich the plugin configuration to allow the user to lock down the encoding and ensure reproducible tests.

          The same applies to the {{goals.txt}}.
          Right now, the {{verify.bsh}} is read using the platform's default encoding, making the tests platform-dependent. We should enrich the plugin configuration to allow the user to lock down the encoding and ensure reproducible tests.

          The same applies to the {{goals.txt}} and {{profiles.txt}}.
          Attachment file-encoding.patch [ 33645 ]
          Patch Submitted [Yes]
          Hide
          Benjamin Bentmann added a comment -

          Here is the proposed patch, following our current proposal about source file encoding.

          Show
          Benjamin Bentmann added a comment - Here is the proposed patch, following our current proposal about source file encoding .
          Benjamin Bentmann created issue -

            People

            • Assignee:
              Benjamin Bentmann
              Reporter:
              Benjamin Bentmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development