Maven Invoker Plugin
  1. Maven Invoker Plugin
  2. MINVOKER-114

Update plugin code to use Java 5 language features

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      (Huge patch attached. Hopefully it can get reviewed/applied soon, before it becomes stale. Luckily the patch consists only of low-risk changes that shouldn't affect the logic functionality.)

      Since the plugin now requires Java 5 anyways (MINVOKER-111), might as well update the code to take advantage of better language features.

      • Removed all unavoidable "raw type" warnings.
      • Where possible/equivalent, converted Iterator-based loops to enhanced for loops.
      • Removed unnecessary dependencies to Iterator.
      • Removed unnecessary casts.
      • Enabled "useJava5" parameter of modello-maven-plugin.

      These changes should make it easier to maintain the code later.

      1. invoker-java-5.patch
        56 kB
        luke w patterson

        Activity

        luke w patterson created issue -
        Olivier Lamy (*$^¨%`£) made changes -
        Field Original Value New Value
        Assignee Olivier Lamy [ olamy ]
        Olivier Lamy (*$^¨%`£) made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 10:28:53 UTC 2015 [ 1428229733495 ]
        Mark Thomas made changes -
        Workflow jira [ 12721822 ] Default workflow, editable Closed status [ 12762069 ]
        Mark Thomas made changes -
        Flags Patch [ 10430 ]
        Patch Submitted Yes [ 10763 ]
        Mark Thomas made changes -
        Project Import Mon Apr 06 00:02:09 UTC 2015 [ 1428278529346 ]
        Mark Thomas made changes -
        Workflow jira [ 12959411 ] Default workflow, editable Closed status [ 12996367 ]

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            luke w patterson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development